Skip to content

fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
May 13, 2026
Merged

fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events #4575

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17a9a7b
fix(console): match child-workflow inner blocks by instanceId when re…
waleedlatif1 May 13, 2026
5754939
fix(console): drop noisy warn when reconcile finds no matching entry
waleedlatif1 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(console): drop noisy warn when reconcile finds no matching entry
  • Loading branch information
@waleedlatif1
waleedlatif1 committed May 13, 2026
commit 575493959fd10cefecba01ea01feaf81184ec973
10 changes: 0 additions & 10 deletions apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-execution-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,16 +543,6 @@ function reconcileChildTraceSpans(
? findConsoleEntryForSpan(workflowId, executionId, childWorkflowInstanceId, span)
: undefined
if (span.blockId) {
if (!matchingEntry) {
logger.warn('reconcileChildTraceSpans found no matching console entry for span', {
workflowId,
executionId,
spanBlockId: span.blockId,
childWorkflowInstanceId,
spanExecutionOrder: span.executionOrder,
spanIterationIndex: span.iterationIndex,
})
}
const errorMessage = normalizeSpanError(span.output?.error)
updateConsole(
span.blockId,
Expand Down
Loading