Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR replaces a call to the shared
Confidence Score: 3/5The change introduces a duplicate copy of the hidden-tool list that is no longer tied to the authoritative source, which could cause internal tool calls to appear in the UI if the shared list is updated without a matching edit here. The inlined HIDDEN_TOOL_NAMES set matches hidden-tools.ts today, but the two lists are now independently maintained. Since hidden-tools.ts is still the active source for four other consumers, a future addition there won't filter in message-content.tsx, silently surfacing implementation-level tool calls in the rendered message UI. apps/sim/app/workspace/[workspaceId]/home/components/message-content/message-content.tsx — the inlined tool-name set needs to be reconciled with the shared source in lib/copilot/tools/client/hidden-tools.ts. Important Files Changed
Reviews (1): Last reviewed commit: "Fix" | Re-trigger Greptile |
| const HIDDEN_TOOL_NAMES = new Set([ | ||
| 'tool_search_tool_regex', | ||
| 'load_agent_skill', | ||
| 'load_custom_tool', | ||
| ]) |
There was a problem hiding this comment.
hidden-tools.ts still exists and is the authoritative source consumed by use-chat.ts, store-utils.ts, tool.ts, and display-message.ts. By inlining a second copy of HIDDEN_TOOL_NAMES here, any future addition to the shared set (e.g. a new internal tool) won't be picked up by parseBlocks, so those tool calls will leak into the rendered UI while every other consumer filters them correctly. The simpler fix is to restore the import of isToolHiddenInUi from @/lib/copilot/tools/client/hidden-tools.
Summary
Fix tool hidden in ui
Type of Change
Testing
Manual
Checklist