Skip to content

refactor(tables): row selection as discriminated union #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
May 6, 2026
Merged

refactor(tables): row selection as discriminated union #4466

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22b555e
fix(tables): decouple master checkbox from cell-range, add allRowsSel…
waleedlatif1 May 6, 2026
d1c0eed
refactor(tables): row selection as discriminated union
waleedlatif1 May 6, 2026
3fa050d
fix(tables): clear row selection after context-menu delete
waleedlatif1 May 6, 2026
0f986cf
chore(tables): address review nits on row selection refactor
waleedlatif1 May 6, 2026
fa8733c
chore(tables): rename rowSelectionChanged to cellRangeRowChanged
waleedlatif1 May 6, 2026
e64787e
fix(tables): guard context-menu delete on stale rows, preserve select…
waleedlatif1 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(tables): address review nits on row selection refactor 
- guard selectedRowCount 'all' branch on contextRow membership in rows
- restore blank line between row-selection helpers and constants
  • Loading branch information
@waleedlatif1
waleedlatif1 committed May 6, 2026
commit 0f986cf65f569c11b3a115fdb0ab217ae775b17f
5 changes: 4 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ function rowSelectionCoversAll(sel: RowSelection, rows: TableRowType[]): boolean
for (const r of rows) if (!sel.ids.has(r.id)) return false
return true
}

const COL_WIDTH_MIN = 80
Comment thread
waleedlatif1 marked this conversation as resolved.
const COL_WIDTH_AUTO_FIT_MAX = 1000
// Wide enough to host the row-number + per-row run button side by side.
Expand Down Expand Up @@ -2448,7 +2449,9 @@ export function Table({
const contextRow = contextMenu.isOpen ? contextMenu.row : null
Comment thread
waleedlatif1 marked this conversation as resolved.
if (!contextRow) return 1

if (rowSelection.kind === 'all') return Math.max(rows.length, 1)
if (rowSelection.kind === 'all') {
return rows.some((r) => r.id === contextRow.id) ? Math.max(rows.length, 1) : 1
}

if (rowSelection.kind === 'some' && rowSelection.ids.has(contextRow.id)) {
let count = 0
Expand Down
Loading