improvement(ui): rename user-facing "execution" to "run"#4176
improvement(ui): rename user-facing "execution" to "run"#4176waleedlatif1 merged 5 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Cancellation behavior: Updates Reviewed by Cursor Bugbot for commit 3454745. Configure here. |
Greptile SummaryThis PR renames user-facing "execution" terminology to "run" across the app UI, emails, search suggestions, and docs, and adds an optimistic DB status update in the cancel API route so the UI reflects Two missed renames remain in the user-facing string surface: Confidence Score: 5/5Safe to merge; all remaining findings are minor P2 copy inconsistencies with no runtime impact. The functional change (optimistic DB cancel update) is well-guarded with a WHERE clause, a try/catch, and solid test coverage. The rename sweep is thorough with only two P2 copy misses found. No logic, security, or data-integrity issues. apps/sim/lib/logs/search-suggestions.ts (line 607) and apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-execution-utils.ts (line 655) have leftover "execution" copy. Important Files Changed
Sequence DiagramsequenceDiagram
participant UI
participant CancelAPI as Cancel API Route
participant Redis as Redis (markExecutionCancelled)
participant DB as Database
participant Executor
UI->>CancelAPI: POST /cancel
CancelAPI->>Redis: markExecutionCancelled(executionId)
Redis-->>CancelAPI: { durablyRecorded: true }
CancelAPI->>DB: UPDATE SET status='cancelled' WHERE executionId=? AND status='running'
DB-->>CancelAPI: OK (UI now sees 'cancelled' immediately)
CancelAPI-->>UI: { success: true }
Note over Executor: Still processing...
Executor->>Redis: Reads cancellation flag
Executor->>DB: Writes final 'cancelled' status
|
Summary
Type of Change
Testing
Tested manually
Checklist