Skip to content

fix(blocks): correct required field validation for Jira and Confluence blocks #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Apr 15, 2026
+9 −16
Merged

fix(blocks): correct required field validation for Jira and Confluence blocks #4172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f141019
fix(blocks): correct required field validation for Jira and Confluenc…
waleedlatif1 Apr 15, 2026
9e59b60
fix(blocks): remove projectId dependsOn gate for update fields, requi…
waleedlatif1 Apr 15, 2026
57e3449
lint
waleedlatif1 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/sim/blocks/blocks/confluence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,15 @@ export const ConfluenceBlock: BlockConfig<ConfluenceResponse> = {
title: 'Title',
type: 'short-input',
placeholder: 'Enter title for the page',
required: { field: 'operation', value: 'create' },
condition: { field: 'operation', value: ['create', 'update'] },
},
{
id: 'content',
title: 'Content',
type: 'long-input',
placeholder: 'Enter content for the page',
required: { field: 'operation', value: 'create' },
condition: { field: 'operation', value: ['create', 'update'] },
},
{
Expand Down Expand Up @@ -766,6 +768,7 @@ export const ConfluenceV2Block: BlockConfig<ConfluenceResponse> = {
title: 'Title',
type: 'short-input',
placeholder: 'Enter title',
required: { field: 'operation', value: ['create', 'create_blogpost'] },
condition: {
field: 'operation',
value: ['create', 'update', 'create_blogpost', 'update_blogpost', 'update_space'],
Expand All @@ -776,6 +779,7 @@ export const ConfluenceV2Block: BlockConfig<ConfluenceResponse> = {
title: 'Content',
type: 'long-input',
placeholder: 'Enter content',
required: { field: 'operation', value: 'create' },
Comment thread
waleedlatif1 marked this conversation as resolved.
Outdated
condition: {
field: 'operation',
value: ['create', 'update', 'create_blogpost', 'update_blogpost'],
Expand Down
6 changes: 3 additions & 3 deletions apps/sim/blocks/blocks/jira.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const JiraBlock: BlockConfig<JiraResponse> = {
placeholder: 'Select Jira project',
dependsOn: ['credential', 'domain'],
mode: 'basic',
required: { field: 'operation', value: ['write', 'update', 'read-bulk'] },
required: { field: 'operation', value: ['write', 'read-bulk'] },
Comment thread
waleedlatif1 marked this conversation as resolved.
},
// Manual project ID input (advanced mode)
{
Expand All @@ -102,7 +102,7 @@ export const JiraBlock: BlockConfig<JiraResponse> = {
placeholder: 'Enter Jira project ID',
dependsOn: ['credential', 'domain'],
mode: 'advanced',
required: { field: 'operation', value: ['write', 'update', 'read-bulk'] },
required: { field: 'operation', value: ['write', 'read-bulk'] },
},
// Issue selector (basic mode)
{
Expand Down Expand Up @@ -218,7 +218,7 @@ export const JiraBlock: BlockConfig<JiraResponse> = {
id: 'summary',
title: 'New Summary',
type: 'short-input',
required: true,
required: { field: 'operation', value: 'write' },
placeholder: 'Enter new summary for the issue',
dependsOn: ['projectId'],
condition: { field: 'operation', value: ['update', 'write'] },
Expand Down
Loading