Skip to content

fix(atlassian): unify error message extraction across all routes #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Apr 13, 2026
Merged

fix(atlassian): unify error message extraction across all routes #4135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a71a23d
fix(atlassian): unify error message extraction across all Jira, JSM, …
waleedlatif1 Apr 13, 2026
bdf3ce3
fix: address PR review comments from Bugbot
waleedlatif1 Apr 13, 2026
29efba3
refactor: remove re-exports from jsm/utils and import directly from s…
waleedlatif1 Apr 13, 2026
2c8eaa8
regen docs
waleedlatif1 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: address PR review comments from Bugbot 
- Remove debug logger.info for formAnswers in JSM request route
- Restore user-friendly spaceId error message in Confluence create-page route
- Restore details field in Jira write and update route error responses

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Apr 13, 2026
commit bdf3ce330057fd52bedcaa21eea489137d5965e7
9 changes: 5 additions & 4 deletions apps/sim/app/api/tools/confluence/create-page/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,11 @@ export async function POST(request: NextRequest) {
statusText: response.statusText,
error: errorText,
})
return NextResponse.json(
{ error: parseAtlassianErrorMessage(response.status, response.statusText, errorText) },
{ status: response.status }
)
let errorMessage = parseAtlassianErrorMessage(response.status, response.statusText, errorText)
if (errorMessage.includes("'spaceId'") && errorMessage.includes('Long')) {
errorMessage = 'Invalid Space ID. Use the list spaces operation to find valid space IDs.'
}
return NextResponse.json({ error: errorMessage }, { status: response.status })
}

const data = await response.json()
Expand Down
5 changes: 4 additions & 1 deletion apps/sim/app/api/tools/jira/update/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,10 @@ export async function PUT(request: NextRequest) {
})

return NextResponse.json(
{ error: parseAtlassianErrorMessage(response.status, response.statusText, errorText) },
{
error: parseAtlassianErrorMessage(response.status, response.statusText, errorText),
details: errorText,
},
{ status: response.status }
)
}
Expand Down
5 changes: 4 additions & 1 deletion apps/sim/app/api/tools/jira/write/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ export async function POST(request: NextRequest) {
})

return NextResponse.json(
{ error: parseAtlassianErrorMessage(response.status, response.statusText, errorText) },
{
error: parseAtlassianErrorMessage(response.status, response.statusText, errorText),
details: errorText,
},
{ status: response.status }
)
}
Expand Down
6 changes: 0 additions & 6 deletions apps/sim/app/api/tools/jsm/request/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,6 @@ export async function POST(request: NextRequest) {
const url = `${baseUrl}/request`

logger.info('Creating request at:', { url, serviceDeskId, requestTypeId })
logger.info('Raw formAnswers param:', {
formAnswers,
type: typeof formAnswers,
isObject: typeof formAnswers === 'object',
keys: formAnswers && typeof formAnswers === 'object' ? Object.keys(formAnswers) : null,
})

const requestBody: Record<string, unknown> = {
serviceDeskId,
Expand Down
Loading