The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 13, 2026 11:25pm

@BugBot review

PR Summary

Medium Risk
Changes default focus behavior for shared ModalContent/SModalContent and tabbed modals, which may affect keyboard flow across many dialogs despite being limited to UI focus management.

Overview
Improves UX around text entry by making emcn modals auto-focus the first visible text input/textarea (caret placed at end) instead of the close button, and by focusing the first text field when ModalTabs switches panels.

Removes scattered autoFocus props from multiple modals and replaces one-off focusing in IntegrationsManager with the new helper. Also tightens chat focus behavior by re-focusing the textarea after resource/file drops in UserInput and when switching the workflow panel to the copilot tab.

^{Reviewed by Cursor Bugbot for commit 9261f15. Bugbot is set up for automated code reviews on this repo. Configure here.}

@BugBot review

Greptile Summary

This PR centralises modal auto-focus by introducing a shared focusFirstTextInputIn / focusFirstTextInput utility and wiring it as the default onOpenAutoFocus handler on both ModalContent and SModalContent. It also upgrades ModalTabs to re-focus the first text input on tab switch, adds copilot-panel and user-input focus on mount, and removes the now-redundant autoFocus attributes scattered across individual modals.

All remaining findings are P2 style/documentation items that do not block merge.

Confidence Score: 5/5

Safe to merge — all findings are non-blocking P2 style and documentation issues.

The core auto-focus utility is well-written (visibility guard, caret placement, setSelectionRange error guard). The ModalTabs RAF timing correctly lets React commit before querying data-state. Removed autoFocus props are safely replaced by the centralised handler. The three P2 comments are about hook ordering, a misleading JSDoc, and an undocumented isInitialView behaviour change — none affect correctness.

apps/sim/app/workspace/[workspaceId]/settings/components/integrations/integrations-manager.tsx (hook ordering), apps/sim/components/emcn/components/modal/modal.tsx (ModalTabsContent JSDoc)

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Modal / SModal opens] --> B[onOpenAutoFocus fires on DialogContent]
    B --> C[focusFirstTextInput]
    C --> D{Find first visible\ntext input in dialog}
    D -- found --> E[focus + caret at end]
    D -- not found --> F[Radix default focus runs]

    G[ModalTabs tab changes] --> H[handleValueChange]
    H --> I[requestAnimationFrame]
    I --> J{Find active tabpanel\ndata-state=active}
    J -- found --> K[focusFirstTextInputIn panel]
    J -- not found --> L[no-op]

    M[UserInput mounts] --> N[requestAnimationFrame on mount]
    N --> O[textareaRef.current?.focus]

    P[Panel activeTab → copilot] --> Q[setTimeout 0ms]
    Q --> R[document.querySelector textarea]
    R --> S[textarea?.focus]

_{Reviews (1): Last reviewed commit: "Auto-focus mothership task chats" | Re-trigger Greptile}