Skip to content

fix(trigger): handle Drive rate limits, 410 page token expiry, and clean up comments #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Apr 11, 2026
Merged

fix(trigger): handle Drive rate limits, 410 page token expiry, and clean up comments #4112

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f503f6
fix(trigger): handle Drive rate limits, 410 page token expiry, and cl…
waleedlatif1 Apr 11, 2026
1ba6339
fix(trigger): treat Drive rate limits as success to preserve failure …
waleedlatif1 Apr 11, 2026
ccbc151
fix(trigger): distinguish Drive 403 rate limits from permission error…
waleedlatif1 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(trigger): treat Drive rate limits as success to preserve failure … 
…budget
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Apr 11, 2026
commit 1ba63399b12ca5439c772c5cd9bde5d9d373a76c
19 changes: 13 additions & 6 deletions apps/sim/lib/webhooks/polling/google-drive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,13 @@ export const googleDrivePollingHandler: PollingProviderHandler = {
)
return 'success'
Comment thread
waleedlatif1 marked this conversation as resolved.
}
if (error instanceof Error && error.name === 'DriveRateLimitError') {
await markWebhookSuccess(webhookId, logger)
logger.warn(
`[${requestId}] Drive API rate limited for webhook ${webhookId}, skipping to retry next poll cycle`
)
return 'success'
}
logger.error(`[${requestId}] Error processing Google Drive webhook ${webhookId}:`, error)
await markWebhookFailed(webhookId, logger)
return 'failure'
Expand Down Expand Up @@ -207,9 +214,9 @@ async function getStartPageToken(
const status = response.status
const errorData = await response.json().catch(() => ({}))
if (status === 403 || status === 429) {
throw new Error(
`Drive API rate limit (${status}) — skipping to retry next poll cycle: ${JSON.stringify(errorData)}`
)
const err = new Error(`Drive API rate limit (${status}): ${JSON.stringify(errorData)}`)
err.name = 'DriveRateLimitError'
throw err
Comment thread
waleedlatif1 marked this conversation as resolved.
}
throw new Error(
`Failed to get Drive start page token: ${status} - ${JSON.stringify(errorData)}`
Expand Down Expand Up @@ -261,9 +268,9 @@ async function fetchChanges(
throw err
}
if (status === 403 || status === 429) {
throw new Error(
`Drive API rate limit (${status}) — skipping to retry next poll cycle: ${JSON.stringify(errorData)}`
)
const err = new Error(`Drive API rate limit (${status}): ${JSON.stringify(errorData)}`)
err.name = 'DriveRateLimitError'
throw err
}
throw new Error(`Failed to fetch Drive changes: ${status} - ${JSON.stringify(errorData)}`)
}
Expand Down
Loading