chore(triggers): deprecate trigger-save subblock#4107
chore(triggers): deprecate trigger-save subblock#4107waleedlatif1 wants to merge 1 commit intostagingfrom
Conversation
Remove the defunct triggerSave subblock from all 102 trigger definitions, the SubBlockType union, SYSTEM_SUBBLOCK_IDS, tool params, and command templates. Retain the backwards-compat filter in getTrigger() for any legacy stored data.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Keeps backward compatibility by filtering any persisted Reviewed by Cursor Bugbot for commit 7349b13. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7349b13. Configure here.
| triggerId, | ||
| condition: { field: 'selectedTriggerId', value: triggerId }, | ||
| }) | ||
| blocks.push() |
There was a problem hiding this comment.
Leftover no-op blocks.push() call after removal
Low Severity
The triggerSave block object was removed from the blocks.push(...) call, but the empty blocks.push() invocation itself was left behind. This is a harmless no-op at runtime (it pushes nothing to the array), but it's clearly an accidental leftover from the refactor — the entire statement including blocks.push() was meant to be deleted, not just its argument.
Reviewed by Cursor Bugbot for commit 7349b13. Configure here.
Summary
triggerSavesubblock from all 102 trigger definitions across every providertrigger-savefromSubBlockTypeunion,SYSTEM_SUBBLOCK_IDS, tool params, and command templatesgetTrigger()to safely handle any legacy stored dataType of Change
Testing
tsc --noEmitpasses with zero errorsChecklist