The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 11, 2026 1:43am

PR Summary

Medium Risk
Medium risk because it refactors core realtime room-join and operation emission paths; regressions could break collaboration presence/updates or leave users stuck without realtime despite being connected.

Overview
Introduces a SocketJoinController state machine (with capped exponential backoff retries) to coordinate workflow room membership and ignore stale join results during rapid workflow switching.

Updates the client socket-provider to use explicit vs route workflow targets, gate presence/cursor/selection/state events to the currently visible workflow, and prevent emitting operations/updates when the socket is not joined to the intended room (including changing emitWorkflowOperation to require an explicit workflowId).

Improves UX around realtime disruptions by adding an isRetryingWorkflowJoin flag, surfacing a unified “Reconnecting…”/“Joining workflow…” notification, and expanding server join-workflow-error payloads to include workflowId, code, and retryable (with new tests covering the join controller/target helpers, operation queue gating, and server handler errors).

^{Reviewed by Cursor Bugbot for commit e5f55af. Configure here.}

Greptile Summary

This PR introduces a SocketJoinController state machine to coordinate Socket.IO room membership during workflow switching, replacing the previous ad-hoc join/leave logic. The controller centralises all join, leave, retry, and blocked-workflow logic into a pure, testable class that emits SocketJoinCommand objects, while the provider simply executes those commands. The refactor eliminates a class of race conditions where rapid workflow switching could leave the client in the wrong room or apply stale server responses.

The overall architecture is well-designed and comprehensively tested. Two minor cleanups are worth addressing before merge: a misleading log message when workflow visibility guards fire, and a dead retriesExhausted field in the error-result interface that is always false.

Confidence Score: 5/5

Safe to merge; both remaining findings are P2 style/cleanup suggestions with no impact on runtime correctness.

The core state-machine design is sound, all key race-condition scenarios are covered by unit tests, and the refactor correctly preserves operation-cancellation semantics on workflow leave. The two open findings are a misleading log level and a dead interface field — neither affects runtime behavior.

No files require special attention; the two style suggestions are in socket-provider.tsx (log message) and socket-join-controller.ts (dead interface field).

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant UI as UI / URL change
    participant SP as SocketProvider
    participant JC as SocketJoinController
    participant S as Socket.IO Server

    UI->>SP: urlWorkflowId changes → requestWorkflow("B")
    SP->>JC: requestWorkflow("B")
    JC-->>SP: [join "B"]
    SP->>S: emit join-workflow{B}
    Note over SP: pendingJoin="B", currentWorkflowId still "A"<br/>Cursors hidden (activeId≠currentId)

    alt Rapid switch to C before response
        UI->>SP: requestWorkflow("C")
        SP->>JC: requestWorkflow("C")
        JC-->>SP: [] (pending for B, flush blocked)
        S-->>SP: join-workflow-success{B}
        SP->>JC: handleJoinSuccess("B")
        JC-->>SP: [join "C"] (desired≠B → ignored)
        SP->>S: emit join-workflow{C}
        S-->>SP: join-workflow-success{C}
        SP->>JC: handleJoinSuccess("C")
        JC-->>SP: [] (apply=true)
        SP->>SP: setCurrentWorkflowId("C")
    else Retryable error
        S-->>SP: join-workflow-error{B, retryable:true}
        SP->>JC: handleJoinError({B, retryable:true})
        JC-->>SP: [schedule-retry{B, delay}]
        SP->>SP: setTimeout → retryJoin("B")
        SP->>JC: retryJoin("B")
        JC-->>SP: [join "B"]
        SP->>S: emit join-workflow{B}
    end

_{Reviews (1): Last reviewed commit: "improvement(sockets): workflow switching..." | Re-trigger Greptile}

bugbot run