-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(knowledge): add token, sentence, recursive, and regex chunkers #4102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9f83f87
feat(knowledge): add token, sentence, recursive, and regex chunkers
waleedlatif1 59f86e9
fix(chunkers): standardize token estimation and use emcn dropdown
waleedlatif1 25abb8a
fix(chunkers): address research audit findings
waleedlatif1 211fe90
fix(chunkers): fix remaining audit issues across all chunkers
waleedlatif1 4872e75
chore(chunkers): lint formatting
waleedlatif1 fc006ee
updated styling
waleedlatif1 c5b9b2f
fix(chunkers): audit fixes and comprehensive tests
waleedlatif1 cb814ff
chore(chunkers): remove unnecessary comments and dead code
waleedlatif1 899fc68
fix(chunkers): address PR review comments
waleedlatif1 4c3508b
fix(chunkers): use consistent overlap pattern in regex fallback
waleedlatif1 3a26dad
fix(chunkers): prevent content loss in word boundary splitting
waleedlatif1 5e8b051
fix(chunkers): restore structured data token ratio and overlap joiner
waleedlatif1 a53f760
lint
waleedlatif1 ec6fa58
fix(chunkers): fall back to character-level overlap in sentence chunker
waleedlatif1 e391efa
fix(chunkers): fix log message and add missing month abbreviations
waleedlatif1 f7fe06a
lint
waleedlatif1 9c624db
fix(chunkers): restore structured data detection threshold to > 2
waleedlatif1 4fd7685
fix(chunkers): pass chunkOverlap to buildChunks in TokenChunker
waleedlatif1 97a0bd4
fix(chunkers): restore separator-as-joiner pattern in splitRecursively
waleedlatif1 2c5a852
feat(knowledge): add JSONL file support for knowledge base uploads
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(chunkers): fix remaining audit issues across all chunkers
- DocsChunker: extract headers from cleaned content (not raw markdown) to fix position mismatch between header positions and chunk positions - DocsChunker: strip export statements and JSX expressions in cleanContent - DocsChunker: fix table merge dedup using equality instead of includes - JsonYamlChunker: preserve path breadcrumbs when nested value fits in one chunk, matching LangChain RecursiveJsonSplitter behavior - StructuredDataChunker: detect 2-column CSV (lowered threshold from >2 to >=1) and use 20% relative tolerance instead of absolute +/-2 - TokenChunker: use sliding window overlap (matching LangChain/Chonkie) where chunks stay within chunkSize instead of exceeding it - utils: splitAtWordBoundaries accepts optional stepChars for sliding window overlap; addOverlap uses newline join instead of space
- Loading branch information
commit 211fe904e31394369fb7173a8f6e62f4fc5ced95
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.