The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 10, 2026 9:16pm

PR Summary

Low Risk
Low risk bug fix confined to dependency/canonical resolution and canvas display-name hydration; main risk is unintended fallback matching returning the wrong member value for a canonical group in edge cases.

Overview
Fixes trigger-mode selector fields (e.g. file/sheet selectors) showing - on the workflow canvas by improving how dependency values are resolved and passed to display-name hydration.

resolveDependencyValue now falls back to scanning all subblocks registered under the same canonical id when the canonical group’s basic/advanced ids don’t produce a value (covers trigger-only members). SubBlockRow now derives credentialId from dependencyValues.credential or the resolved oauthCredential context so useSelectorDisplayName can hydrate trigger selectors correctly.

^{Reviewed by Cursor Bugbot for commit 5d6bc86. Configure here.}

Greptile Summary

This PR fixes the canvas preview for trigger blocks showing - for file-selector and sheet-selector fields when values are already selected. It addresses two root causes: a missing fallback in resolveDependencyValue for trigger-mode subblocks that are intentionally excluded from canonical group structs, and credentialId always resolving to undefined for trigger subblocks that use triggerCredentials rather than credential as their dep key.

Confidence Score: 4/5

Safe to merge with one minor inconsistency: the != null guard preceding the new fallback scan can bypass it when the basic subblock holds an empty string, so the fix may not fire in cleared-field edge cases.

Both root causes are correctly diagnosed and the fixes are targeted. The previous thread concern (using isNonEmptyValue in the scan body) was already resolved. The remaining P2 item — the != null guard on line 290 vs. isNonEmptyValue used everywhere else — is a real inconsistency that could silently suppress the fallback in the empty-string edge case, so a score of 4 rather than 5 reflects that a one-line follow-up is worth making.

apps/sim/lib/workflows/subblocks/visibility.ts — line 290 guard inconsistency

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["resolveDependencyValue(oauthCredential)"] --> B{canonicalId found?}
    B -- No --> C[return values at dependencyKey]
    B -- Yes --> D["getCanonicalValues(group, values)"]
    D --> E["canonicalResult = basicValue OR advancedValue"]
    E --> F{"canonicalResult != null\ncurrently uses != null not isNonEmptyValue"}
    F -- Yes --> G[return canonicalResult]
    F -- No --> H["Fallback scan over canonicalIdBySubBlockId"]
    H --> I{"memberId maps to canonicalId AND isNonEmptyValue?"}
    I -- Yes --> J["return trigger credential value"]
    I -- No --> K[return values at dependencyKey]

    style F fill:#f9c,stroke:#c33
    style J fill:#9f9,stroke:#393

_{Reviews (2): Last reviewed commit: "fix(trigger): use isNonEmptyValue in can..." | Re-trigger Greptile}

@greptile

@cursor review