Skip to content

v0.6.35: additional jira fields, HITL docs, logs cleanup efficiency #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 5 commits into from
Apr 10, 2026
Merged

v0.6.35: additional jira fields, HITL docs, logs cleanup efficiency #4093

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
171485d
fix(tools): handle all Atlassian error formats in parseJsmErrorMessag…
waleedlatif1 Apr 10, 2026
4074109
fix(log): log cleanup sql query (#4087)
TheodoreSpeaks Apr 10, 2026
476669f
docs(openapi): add Human in the Loop section to API reference sidebar…
waleedlatif1 Apr 10, 2026
04c1f8e
feat(tools): add fields parameter to Jira search block (#4091)
waleedlatif1 Apr 10, 2026
3efbd1d
fix(agent): include model in structured response output (#4092)
waleedlatif1 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(tools): handle all Atlassian error formats in parseJsmErrorMessage ( 
#4088)

Update parseJsmErrorMessage to extract errors from all Atlassian API
response formats: errorMessage (JSM), errorMessages array (Jira),
errors[].title RFC 7807 (Confluence/Forms), field-level errors object,
and message (gateway). Remove redundant prefix wrapping so the raw
error message surfaces cleanly through the extractor.
  • Loading branch information
@waleedlatif1
waleedlatif1 authored Apr 10, 2026
commit 171485d3b6740a4b9bcfb6bddb3bda21142c6c94
29 changes: 26 additions & 3 deletions apps/sim/tools/jsm/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,36 @@ export function parseJsmErrorMessage(
): string {
try {
const errorData = JSON.parse(errorText)
// JSM Service Desk: singular errorMessage
if (errorData.errorMessage) {
return `JSM Forms API error: ${errorData.errorMessage}`
return errorData.errorMessage
}
// Jira Platform: errorMessages array
if (Array.isArray(errorData.errorMessages) && errorData.errorMessages.length > 0) {
return errorData.errorMessages.join(', ')
}
// Confluence v2 / Forms API: RFC 7807 errors array
if (Array.isArray(errorData.errors) && errorData.errors.length > 0) {
const err = errorData.errors[0]
if (err?.title) {
return err.detail ? `${err.title}: ${err.detail}` : err.title
}
}
// Jira Platform field-level errors object
if (errorData.errors && !Array.isArray(errorData.errors)) {
const fieldErrors = Object.entries(errorData.errors)
.map(([field, msg]) => `${field}: ${msg}`)
.join(', ')
if (fieldErrors) return fieldErrors
}
// Generic message fallback
if (errorData.message) {
Comment on lines +53 to +76
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Non-TSDoc inline comments violate project standards

The added // comments (// JSM Service Desk: singular errorMessage, // Jira Platform: errorMessages array, etc.) are non-TSDoc comments. The project's global standards explicitly forbid non-TSDoc comments — all documentation should use TSDoc format or be removed.

Context Used: Global coding standards that apply to all files (source)

return errorData.message
}
} catch {
if (errorText) {
return `JSM Forms API error: ${errorText}`
return errorText
}
}
return `JSM Forms API error: ${status} ${statusText}`
return `${status} ${statusText}`
}
Loading