Skip to content

fix(log): log cleanup sql query #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Apr 10, 2026
+8 −27
Merged

fix(log): log cleanup sql query #4087

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9750eaa
fix(log): log cleanup sql query
TheodoreSpeaks Apr 9, 2026
cafe8fe
perf(log): use startedAt index for cleanup query filter
waleedlatif1 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
perf(log): use startedAt index for cleanup query filter 
Switch cleanup WHERE clause from createdAt to startedAt to leverage
the existing composite index (workspaceId, startedAt), converting a
full table scan to an index range scan. Also remove explanatory comment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Apr 10, 2026
commit cafe8fe1f9c7e58f4044e10c5354f643ae86a77c
9 changes: 1 addition & 8 deletions apps/sim/app/api/logs/cleanup/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ export async function GET(request: NextRequest) {
const retentionDate = new Date()
retentionDate.setDate(retentionDate.getDate() - Number(env.FREE_PLAN_LOG_RETENTION_DAYS || '7'))

/**
* Subquery: workspace IDs whose billed account user has no active paid
* subscription. Kept as a subquery (not materialized into JS) so the
* generated SQL is `WHERE workspace_id IN (SELECT ...)` — this avoids
* PostgreSQL's 65535 bind-parameter limit that was breaking cleanup once
* the free-user count grew beyond ~65k.
*/
const freeWorkspacesSubquery = db
.select({ id: workspace.id })
.from(workspace)
Expand Down Expand Up @@ -94,7 +87,7 @@ export async function GET(request: NextRequest) {
.where(
and(
inArray(workflowExecutionLogs.workspaceId, freeWorkspacesSubquery),
lt(workflowExecutionLogs.createdAt, retentionDate)
lt(workflowExecutionLogs.startedAt, retentionDate)
Comment thread
waleedlatif1 marked this conversation as resolved.
)
)
.limit(BATCH_SIZE)
Expand Down
Loading