Skip to content

fix(trigger): add @react-email/components to additionalPackages#4068

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/fix-react-email-trigger
Apr 9, 2026
Merged

fix(trigger): add @react-email/components to additionalPackages#4068
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/fix-react-email-trigger

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Add @react-email/components to Trigger.dev additionalPackages to fix reactDOMServer.renderToPipeableStream is not a function error in lifecycle email task
  • @react-email/components has a nested copy of @react-email/render v1.0.5 that needs react-dom/server available at runtime

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 9, 2026 6:08am

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 9, 2026

PR Summary

Low Risk
Low risk, single config change that only affects Trigger.dev build packaging; main risk is slightly larger bundle or dependency resolution differences at runtime.

Overview
Fixes Trigger.dev runtime packaging by adding @react-email/components to additionalPackages in apps/sim/trigger.config.ts, ensuring the email rendering stack has required React Email dependencies available at execution time.

Reviewed by Cursor Bugbot for commit 11cd1cd. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 9, 2026

Greptile Summary

Adds @react-email/components to the Trigger.dev additionalPackages list alongside the already-present react-dom and @react-email/render entries. This prevents the build system from tree-shaking/bundling the package and ensures its nested @react-email/render v1.0.5 dependency can resolve react-dom/server at runtime, fixing the reactDOMServer.renderToPipeableStream is not a function error in the lifecycle email task.

Confidence Score: 5/5

Safe to merge — minimal, targeted config change with no logic or type-safety concerns.

Single-line addition to a build configuration list, consistent with the existing pattern of other packages in additionalPackages. The fix directly addresses the described runtime error and introduces no new risks.

No files require special attention.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename Overview
apps/sim/trigger.config.ts Adds @react-email/components to additionalPackages so Trigger.dev treats it as an external runtime dependency, resolving the missing react-dom/server error caused by its bundled copy of @react-email/render.

Reviews (1): Last reviewed commit: "fix(trigger): add @react-email/component..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit d778b3d into staging Apr 9, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/fix-react-email-trigger branch April 9, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant