Skip to content

improvement(polling): fix correctness and efficiency across all polling handlers #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 9 commits into from
Apr 9, 2026
Merged

improvement(polling): fix correctness and efficiency across all polling handlers #4067

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4268465
improvement(polling): fix correctness and efficiency across all polli…
waleedlatif1 Apr 9, 2026
f69895f
fix(rss): align idempotency key GUID fallback with tracking/filter guard
waleedlatif1 Apr 9, 2026
a0c2a75
removed comments
waleedlatif1 Apr 9, 2026
cc1e911
fix(imap): clear stale UID when UIDVALIDITY changes during state merge
waleedlatif1 Apr 9, 2026
c8f5ed3
fix(rss): skip items with no identifiable GUID to avoid idempotency k…
waleedlatif1 Apr 9, 2026
992935f
fix(schedules): convert dynamic import of getWorkflowById to static i…
waleedlatif1 Apr 9, 2026
9ed0b82
fix(imap): preserve fresh UID after UIDVALIDITY reset in state merge
waleedlatif1 Apr 9, 2026
2949517
improvement(polling): remove trigger.dev dispatch, use synchronous Re…
waleedlatif1 Apr 9, 2026
f82c7f7
fix(polling): decouple outlook page size from total email cap so pagi…
waleedlatif1 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(rss): skip items with no identifiable GUID to avoid idempotency k… 
…ey collisions
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Apr 9, 2026
commit c8f5ed32dd262eb558c3e3ad8ccde256adefc5a6
7 changes: 7 additions & 0 deletions apps/sim/lib/webhooks/polling/rss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,13 @@ async function processRssItems(
item.link ||
(item.title && item.pubDate ? `${item.title}-${item.pubDate}` : '')
Comment thread
waleedlatif1 marked this conversation as resolved.

if (!itemGuid) {
logger.warn(
`[${requestId}] Skipping RSS item with no identifiable GUID for webhook ${webhookData.id}`
)
continue
}

await pollingIdempotency.executeWithIdempotency(
'rss',
`${webhookData.id}:${itemGuid}`,
Expand Down