Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Removes the previous “fallback to in-process resume” behavior when async dispatch fails; the endpoint now logs the failure and returns Reviewed by Cursor Bugbot for commit 85a1794. Configure here. |
Greptile SummaryThis PR adds a missing Confidence Score: 5/5Safe to merge — single-line targeted fix with no risk to existing paths. The change adds one field ( No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/resume/[workflowId]/[executionId]/[contextId]/route.ts | Adds statusUrl to the async (202) resume response, consistent with the execute route pattern; pre-existing catch (error: any) violates the no-any rule but is out of scope for this PR. |
Sequence Diagram
sequenceDiagram
participant Caller as API Caller
participant Resume as POST /api/resume/[workflowId]/[executionId]/[contextId]
participant Queue as Job Queue (BullMQ / JobQueue)
participant Jobs as GET /api/jobs/[jobId]
Caller->>Resume: POST with resumeInput
Resume->>Resume: validateWorkflowAccess
Resume->>Resume: preprocessExecution
Resume->>Resume: PauseResumeManager.enqueueOrStartResume
alt executionMode === 'async'
Resume->>Queue: enqueue 'resume-execution'
Queue-->>Resume: jobId
Resume-->>Caller: 202 { async: true, jobId, executionId, statusUrl }
Note over Caller,Jobs: Caller polls statusUrl
Caller->>Jobs: GET /api/jobs/{jobId}
Jobs-->>Caller: { status, output, ... }
else executionMode === 'stream'
Resume-->>Caller: SSE stream
else executionMode === 'sync' (default)
Resume->>Resume: startResumeExecution (await)
Resume-->>Caller: 200 { success, output, metadata }
end
Reviews (1): Last reviewed commit: "fix(hitl): async resume" | Re-trigger Greptile
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 85a1794. Configure here.
Summary
Async resume response shape should have status url for polling executions status.
Type of Change
Testing
Test in staging env.
Checklist