Skip to content

fix(kb): disable connectors after repeated sync failures #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Apr 8, 2026
Merged

fix(kb): disable connectors after repeated sync failures #4046

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb92699
fix(kb): improve error logging when connector token resolution fails
waleedlatif1 Apr 8, 2026
e66d4e5
feat(kb): disable connectors after 10 consecutive sync failures
waleedlatif1 Apr 8, 2026
6b78d23
fix(kb): disable sync button for disabled connectors, use amber badge…
waleedlatif1 Apr 8, 2026
780ac55
fix(kb): address PR review comments for disabled connector feature
waleedlatif1 Apr 8, 2026
c3ea8e1
fix(kb): move resolveAccessToken inside try/catch for circuit-breaker…
waleedlatif1 Apr 8, 2026
23a44de
fix(kb): remove dead interval branch when re-enabling connector
waleedlatif1 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(kb): move resolveAccessToken inside try/catch for circuit-breaker… 
… coverage

Token resolution failures (e.g. revoked OAuth tokens) were thrown before
the try/catch block, bypassing consecutiveFailures tracking entirely.
Also removes dead `if (refreshed)` guards at mid-sync refresh sites since
resolveAccessToken now always returns a string or throws.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Apr 8, 2026
commit c3ea8e1a382f3f4e32b636155056b0e7c56400d2
10 changes: 4 additions & 6 deletions apps/sim/lib/knowledge/connectors/sync-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,6 @@ export async function executeSync(
const userId = kbRows[0].userId
const sourceConfig = connector.sourceConfig as Record<string, unknown>

let accessToken = await resolveAccessToken(connector, connectorConfig, userId)

const lockResult = await db
.update(knowledgeConnector)
.set({ status: 'syncing', updatedAt: new Date() })
Expand Down Expand Up @@ -349,6 +347,8 @@ export async function executeSync(
let syncExitedCleanly = false

try {
let accessToken = await resolveAccessToken(connector, connectorConfig, userId)

const externalDocs: ExternalDocument[] = []
let cursor: string | undefined
let hasMore = true
Expand All @@ -365,8 +365,7 @@ export async function executeSync(

for (let pageNum = 0; hasMore && pageNum < MAX_PAGES; pageNum++) {
if (pageNum > 0 && connectorConfig.auth.mode === 'oauth') {
const refreshed = await resolveAccessToken(connector, connectorConfig, userId)
if (refreshed) accessToken = refreshed
accessToken = await resolveAccessToken(connector, connectorConfig, userId)
}

const page = await connectorConfig.listDocuments(
Expand Down Expand Up @@ -504,8 +503,7 @@ export async function executeSync(

if (deferredOps.length > 0) {
if (connectorConfig.auth.mode === 'oauth') {
const refreshed = await resolveAccessToken(connector, connectorConfig, userId)
if (refreshed) accessToken = refreshed
accessToken = await resolveAccessToken(connector, connectorConfig, userId)
}

const hydrated = await Promise.allSettled(
Expand Down
Loading