Skip to content

refactor(polling): consolidate polling services into provider handler pattern #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Apr 8, 2026
Merged

refactor(polling): consolidate polling services into provider handler pattern #4035

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f64944
refactor(polling): consolidate polling services into provider handler…
waleedlatif1 Apr 8, 2026
21f49cc
polish(polling): extract lock TTL constant and remove unnecessary typ…
waleedlatif1 Apr 8, 2026
4a1000c
fix(polling): address PR review feedback
waleedlatif1 Apr 8, 2026
7828b1e
fix(polling): use literal for maxDuration segment config
waleedlatif1 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(polling): use literal for maxDuration segment config 
Next.js requires segment config exports to be statically analyzable
literals. Using a variable reference caused build failure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Apr 8, 2026
commit 7828b1e6849484d54fdbcb54b2f5d842f25d0155
4 changes: 2 additions & 2 deletions apps/sim/app/api/webhooks/poll/[provider]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import { pollProvider, VALID_POLLING_PROVIDERS } from '@/lib/webhooks/polling'

const logger = createLogger('PollingAPI')

/** Lock TTL in seconds — matches maxDuration so the lock auto-expires if the function times out. */
/** Lock TTL in seconds — must match maxDuration so the lock auto-expires if the function times out. */
const LOCK_TTL_SECONDS = 180

export const dynamic = 'force-dynamic'
export const maxDuration = LOCK_TTL_SECONDS
export const maxDuration = 180

export async function GET(
request: NextRequest,
Expand Down
Loading