Skip to content

fix(modals): consistent text colors and workspace delete confirmation #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Apr 7, 2026
Merged

fix(modals): consistent text colors and workspace delete confirmation #4017

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd29a29
fix(modals): consistent text colors, copy, and workspace delete confi…
waleedlatif1 Apr 7, 2026
f6f601c
fix(modal): replace useEffect with render-time state reset
waleedlatif1 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(modal): replace useEffect with render-time state reset 
Replace useEffect anti-pattern for resetting confirmation text with
React's recommended "adjusting state during render" pattern. This
ensures stale text is never painted and avoids an extra render cycle.
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Apr 7, 2026
commit f6f601cfe832e9de958115bee1350f6de20eb422
8 changes: 5 additions & 3 deletions ...d]/w/components/sidebar/components/workflow-list/components/delete-modal/delete-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client'

import { useEffect, useState } from 'react'
import { useState } from 'react'
import { Button, Modal, ModalBody, ModalContent, ModalFooter, ModalHeader } from '@/components/emcn'

interface DeleteModalProps {
Expand Down Expand Up @@ -48,12 +48,14 @@ export function DeleteModal({
itemName,
}: DeleteModalProps) {
const [confirmationText, setConfirmationText] = useState('')
const [prevIsOpen, setPrevIsOpen] = useState(false)

useEffect(() => {
if (isOpen !== prevIsOpen) {
setPrevIsOpen(isOpen)
if (isOpen) {
setConfirmationText('')
}
}, [isOpen])
}

const isMultiple = Array.isArray(itemName) && itemName.length > 1
const isSingle = !isMultiple
Expand Down
Loading