Skip to content

refactor(webhooks): extract provider-specific logic into handler registry #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 18 commits into from
Apr 6, 2026
Merged

refactor(webhooks): extract provider-specific logic into handler registry #3973

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cc6b80c
refactor(webhooks): extract provider-specific logic into handler regi…
waleedlatif1 Apr 5, 2026
ffa5864
fix(webhooks): address PR review feedback
waleedlatif1 Apr 5, 2026
403e32f
fix(webhooks): fix build error from union type indexing in processTri…
waleedlatif1 Apr 5, 2026
5d9b95a
fix(webhooks): return 401 when requireAuth is true but no token confi…
waleedlatif1 Apr 5, 2026
7b6b50b
refactor(webhooks): move signature validators into provider handler f…
waleedlatif1 Apr 5, 2026
1f92950
refactor(webhooks): move challenge handlers into provider files
waleedlatif1 Apr 5, 2026
46a1ea0
refactor(webhooks): move fetchAndProcessAirtablePayloads into airtabl…
waleedlatif1 Apr 5, 2026
adf13bc
refactor(webhooks): extract polling config functions into polling-con…
waleedlatif1 Apr 5, 2026
ced7d14
refactor(webhooks): decompose formatWebhookInput into per-provider fo…
waleedlatif1 Apr 5, 2026
0d2f78b
refactor(webhooks): decompose provider-subscriptions into handler reg…
waleedlatif1 Apr 5, 2026
3ad355e
fix(webhooks): fix attio build error, restore imap field, remove dema…
waleedlatif1 Apr 5, 2026
8bcf450
fix(webhooks): remove unused imports from utils.server.ts after rebase
waleedlatif1 Apr 5, 2026
60610b7
fix(webhooks): remove duplicate generic file processing from webhook-…
waleedlatif1 Apr 5, 2026
1478de1
fix(webhooks): validate auth token is set when requireAuth is enabled…
waleedlatif1 Apr 5, 2026
78e6de5
fix(webhooks): remove unintended rejectUnauthorized field from IMAP p…
waleedlatif1 Apr 5, 2026
7afed0d
fix(webhooks): replace crypto.randomUUID() with generateId() in ashby…
waleedlatif1 Apr 5, 2026
220aa91
refactor(webhooks): standardize logger names and remove any types fro…
waleedlatif1 Apr 5, 2026
98b4586
refactor(webhooks): remove remaining any types from deploy.ts
waleedlatif1 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(webhooks): remove remaining any types from deploy.ts 
Replace 3 `catch (error: any)` with `catch (error: unknown)` and
1 `Record<string, any>` with `Record<string, unknown>`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Apr 6, 2026
commit 98b4586df2d75b4634e1b6becbc9840e9b709f36
14 changes: 7 additions & 7 deletions apps/sim/lib/webhooks/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ async function syncCredentialSetWebhooks(params: {
basePath: triggerPath,
credentialSetId,
oauthProviderId,
providerConfig: baseConfig as Record<string, any>,
providerConfig: baseConfig as Record<string, unknown>,
requestId,
deploymentVersionId,
})
Expand Down Expand Up @@ -558,13 +558,13 @@ export async function saveTriggerWebhooksForDeploy({
await restorePreviousSubscriptions()
return { success: false, error: syncResult.error, warnings: collectedWarnings }
}
} catch (error: any) {
} catch (error: unknown) {
logger.error(`[${requestId}] Failed to create webhook for ${block.id}`, error)
await restorePreviousSubscriptions()
return {
success: false,
error: {
message: error?.message || 'Failed to save trigger configuration',
message: (error as Error)?.message || 'Failed to save trigger configuration',
status: 500,
},
warnings: collectedWarnings,
Expand Down Expand Up @@ -621,7 +621,7 @@ export async function saveTriggerWebhooksForDeploy({
updatedProviderConfig: result.updatedProviderConfig as Record<string, unknown>,
externalSubscriptionCreated: result.externalSubscriptionCreated,
})
} catch (error: any) {
} catch (error: unknown) {
logger.error(`[${requestId}] Failed to create external subscription for ${block.id}`, error)
await pendingVerificationTracker.clearAll()
for (const sub of createdSubscriptions) {
Expand Down Expand Up @@ -649,7 +649,7 @@ export async function saveTriggerWebhooksForDeploy({
return {
success: false,
error: {
message: error?.message || 'Failed to create external subscription',
message: (error as Error)?.message || 'Failed to create external subscription',
status: 500,
},
}
Expand Down Expand Up @@ -722,7 +722,7 @@ export async function saveTriggerWebhooksForDeploy({
return { success: false, error: pollingError }
}
}
} catch (error: any) {
} catch (error: unknown) {
await pendingVerificationTracker.clearAll()
logger.error(`[${requestId}] Failed to insert webhook records`, error)
for (const sub of createdSubscriptions) {
Expand Down Expand Up @@ -750,7 +750,7 @@ export async function saveTriggerWebhooksForDeploy({
return {
success: false,
error: {
message: error?.message || 'Failed to save webhook records',
message: (error as Error)?.message || 'Failed to save webhook records',
status: 500,
},
}
Expand Down
Loading