Skip to content

fix(settings): align skeleton loading states with actual page layouts #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Apr 5, 2026
Merged

fix(settings): align skeleton loading states with actual page layouts #3967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5cd0af
fix(settings): align skeleton loading states with actual page layouts
waleedlatif1 Apr 5, 2026
65f512b
lint
waleedlatif1 Apr 5, 2026
b60987d
fix(settings): address PR feedback — deduplicate skeleton, fix import…
waleedlatif1 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Apr 5, 2026
commit 65f512b17e65a8e2986283ddc7ce26f9220cb509
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/settings/[section]/settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import { GeneralSkeleton } from '@/app/workspace/[workspaceId]/settings/componen
import { InboxSkeleton } from '@/app/workspace/[workspaceId]/settings/components/inbox/inbox-skeleton'
import { IntegrationsSkeleton } from '@/app/workspace/[workspaceId]/settings/components/integrations/integrations-skeleton'
import { McpSkeleton } from '@/app/workspace/[workspaceId]/settings/components/mcp/mcp-skeleton'
import { SkillsSkeleton } from '@/app/workspace/[workspaceId]/settings/components/skills/skill-skeleton'
import { RecentlyDeletedSkeleton } from '@/app/workspace/[workspaceId]/settings/components/recently-deleted/recently-deleted-skeleton'
import { SkillsSkeleton } from '@/app/workspace/[workspaceId]/settings/components/skills/skill-skeleton'
Comment thread
waleedlatif1 marked this conversation as resolved.
import { WorkflowMcpServersSkeleton } from '@/app/workspace/[workspaceId]/settings/components/workflow-mcp-servers/workflow-mcp-servers-skeleton'
import type { SettingsSection } from '@/app/workspace/[workspaceId]/settings/navigation'
import {
Expand Down
2 changes: 1 addition & 1 deletion ...orkspace/[workspaceId]/settings/components/recently-deleted/recently-deleted-skeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function RecentlyDeletedSkeleton() {
</div>

{/* Tabs bar */}
<div className='relative flex gap-4 border-b border-[var(--border)] px-4'>
<div className='relative flex gap-4 border-[var(--border)] border-b px-4'>
<Skeleton className='mb-2 h-[20px] w-[32px] rounded-sm' />
<Skeleton className='mb-2 h-[20px] w-[72px] rounded-sm' />
<Skeleton className='mb-2 h-[20px] w-[52px] rounded-sm' />
Expand Down
Loading