-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(knowledge): add Live sync option to KB connectors + fix embedding billing #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8cd90e7
feat(knowledge): add Live sync option to KB connector modal for Max/E…
waleedlatif1 987411c
fix(knowledge): record embedding usage cost for KB document processing
waleedlatif1 3347481
fix(knowledge): simplify embedding billing — use calculateCost, retur…
waleedlatif1 446c506
fix(knowledge): remove dev bypass from hasLiveSyncAccess
waleedlatif1 11d9f83
chore(knowledge): rename sync-intervals to consts, fix stale TSDoc co…
waleedlatif1 26682c1
improvement(knowledge): extract MaxBadge component, capture billing c…
waleedlatif1 47dbe1c
fix(knowledge): add knowledge-base to usage_log_source enum, fix docs…
waleedlatif1 0809ea1
fix(knowledge): generate migration for knowledge-base usage_log_sourc…
waleedlatif1 57f190a
fix(knowledge): add knowledge-base to usage_log_source enum via drizz…
waleedlatif1 4e6cb8f
fix(knowledge): fix search embedding test mocks, parallelize billing …
waleedlatif1 d3c7bff
fix(knowledge): warn when embedding model has no pricing entry
waleedlatif1 9e5d32d
fix(knowledge): call checkAndBillOverageThreshold after embedding usage
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(knowledge): record embedding usage cost for KB document processing
Adds billing tracking to the KB embedding pipeline, which was previously generating OpenAI API calls with no cost recorded. Token counts are now captured from the actual API response and recorded via recordUsage after successful embedding insertion. BYOK workspaces are excluded from billing. Applies to all execution paths: direct, BullMQ, and Trigger.dev.
- Loading branch information
commit 987411ca48d2458566ea65762178a6fc3e0fb35a
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data.usageThe response is cast to
EmbeddingAPIResponseat the TypeScript level, but there's no runtime validation. If an Azure deployment or OpenAI-compatible proxy omits theusagefield (e.g. older API versions or proxies),data.usage.total_tokensthrowsTypeError: Cannot read properties of undefined (reading 'total_tokens'), which would propagate out ofcallEmbeddingAPIand abort the entire batch, preventing document processing from completing.A safe fallback costs nothing in the happy path: