Skip to content

fix(modals): center modals in visible content area and remove open/close animation #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Apr 4, 2026
+0 −9
Merged

fix(modals): center modals in visible content area and remove open/close animation #3937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c80532
fix(modals): center modals in visible content area accounting for sid…
waleedlatif1 Apr 4, 2026
bb1745a
fix(modals): address pr feedback — comment clarity and document panel…
waleedlatif1 Apr 4, 2026
0f471fb
fix(modals): remove open/close animation from modal content
waleedlatif1 Apr 4, 2026
f6e5994
chore(modals): resolve merge conflict with staging
waleedlatif1 Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(modals): address pr feedback — comment clarity and document panel… 
… assumption
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Apr 4, 2026
commit bb1745a666e2a42e4110e0c4e199238649ac648c
2 changes: 1 addition & 1 deletion apps/sim/app/_styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* @see stores/constants.ts for the source of truth
*/
:root {
--sidebar-width: 0px; /* 0 outside workspace; blocking script sets actual value on workspace pages */
--sidebar-width: 0px; /* 0 outside workspace; blocking script always sets actual value on workspace pages */
--panel-width: 320px; /* PANEL_WIDTH.DEFAULT */
--toolbar-triggers-height: 300px; /* TOOLBAR_TRIGGERS_HEIGHT.DEFAULT */
--editor-connections-height: 172px; /* EDITOR_CONNECTIONS_HEIGHT.DEFAULT */
Expand Down
3 changes: 2 additions & 1 deletion apps/sim/components/emcn/components/modal/modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ const ModalContent = React.forwardRef<
)}
style={{
left: isWorkflowPage
? 'calc(50% + (var(--sidebar-width) - var(--panel-width)) / 2)'
? // --panel-width is always the rendered panel width on /w/ routes (panel is never hidden/collapsed)
'calc(50% + (var(--sidebar-width) - var(--panel-width)) / 2)'
: 'calc(var(--sidebar-width) / 2 + 50%)',
...style,
}}
Expand Down
Loading