Skip to content

fix(kb): fix Linear connector GraphQL type errors and tag slot reuse #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 5 commits into from
Apr 3, 2026
Merged

fix(kb): fix Linear connector GraphQL type errors and tag slot reuse #3919

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e12f15f
fix(kb): fix Linear connector GraphQL type errors and tag slot reuse
waleedlatif1 Apr 3, 2026
77839f9
fix(kb): simplify tag slot reuse, revert Linear GraphQL types to String
waleedlatif1 Apr 3, 2026
bcae263
fix(kb): use ID! type for Linear GraphQL filter variables
waleedlatif1 Apr 3, 2026
6e0d016
fix(kb): verify field type when reusing existing tag slots
waleedlatif1 Apr 3, 2026
8b7d5f5
fix(kb): enable search on connector selector dropdowns
waleedlatif1 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(kb): verify field type when reusing existing tag slots 
Add fieldType check to the tag slot reuse logic so a connector with
a matching displayName but different fieldType falls through to fresh
slot allocation instead of silently reusing an incompatible slot.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Apr 3, 2026
commit 6e0d0164213bf48d1c4dd710f25688b16153fabd
11 changes: 7 additions & 4 deletions apps/sim/app/api/knowledge/[id]/connectors/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,18 +172,21 @@ export async function POST(request: NextRequest, { params }: { params: Promise<{
.select({
tagSlot: knowledgeBaseTagDefinitions.tagSlot,
displayName: knowledgeBaseTagDefinitions.displayName,
fieldType: knowledgeBaseTagDefinitions.fieldType,
})
.from(knowledgeBaseTagDefinitions)
.where(eq(knowledgeBaseTagDefinitions.knowledgeBaseId, knowledgeBaseId))

const usedSlots = new Set<string>(existingDefs.map((d) => d.tagSlot))
const existingByName = new Map(existingDefs.map((d) => [d.displayName, d.tagSlot]))
const existingByName = new Map(
existingDefs.map((d) => [d.displayName, { tagSlot: d.tagSlot, fieldType: d.fieldType }])
)

const defsNeedingSlots: typeof enabledDefs = []
for (const td of enabledDefs) {
const existingSlot = existingByName.get(td.displayName)
if (existingSlot) {
tagSlotMapping[td.id] = existingSlot
const existing = existingByName.get(td.displayName)
if (existing && existing.fieldType === td.fieldType) {
tagSlotMapping[td.id] = existing.tagSlot
} else {
defsNeedingSlots.push(td)
}
Expand Down
Loading