Skip to content

feat(logs): add copy link and deep link support for log entries #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Mar 31, 2026
Merged

feat(logs): add copy link and deep link support for log entries #3855

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60496a4
feat(logs): add copy link and deep link support for log entries
waleedlatif1 Mar 31, 2026
5c5a4d8
fix(logs): fetch next page when deep linked log is beyond initial page
waleedlatif1 Mar 31, 2026
0fc5298
fix(logs): move Link icon to emcn and handle clipboard rejections
waleedlatif1 Mar 31, 2026
be5b3df
fix(logs): track isFetching reactively and drop empty-list early-return
waleedlatif1 Mar 31, 2026
1715669
fix(logs): guard deep-link ref clear until query has succeeded
waleedlatif1 Mar 31, 2026
48bdbe5
fix(logs): guard fetchNextPage call until query has succeeded
waleedlatif1 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(logs): track isFetching reactively and drop empty-list early-return 
- Remove  guard that prevented clearing the
  pending ref when filters return no results
- Use  directly in the condition and add it to
  the effect deps so the effect re-triggers after a background refetch
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 31, 2026
commit be5b3dfcd70a9e0ea72f1a48267dde978ab3fd9d
6 changes: 3 additions & 3 deletions apps/sim/app/workspace/[workspaceId]/logs/logs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,18 +429,18 @@ export default function Logs() {
}

useEffect(() => {
if (!pendingExecutionIdRef.current || sortedLogs.length === 0) return
if (!pendingExecutionIdRef.current) return
const targetExecutionId = pendingExecutionIdRef.current
const found = sortedLogs.find((l) => l.executionId === targetExecutionId)
if (found) {
pendingExecutionIdRef.current = null
dispatch({ type: 'TOGGLE_LOG', logId: found.id })
} else if (!logsQuery.hasNextPage) {
pendingExecutionIdRef.current = null
Comment thread
waleedlatif1 marked this conversation as resolved.
} else if (!logsQueryRef.current.isFetching) {
} else if (!logsQuery.isFetching) {
logsQueryRef.current.fetchNextPage()
Comment thread
waleedlatif1 marked this conversation as resolved.
}
}, [sortedLogs, logsQuery.hasNextPage])
}, [sortedLogs, logsQuery.hasNextPage, logsQuery.isFetching])

useEffect(() => {
const timers = refreshTimersRef.current
Expand Down
Loading