Skip to content

feat(workflow): resolve canvas re-rendering and logs perf issues #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adithyaakrishna wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

feat(workflow): resolve canvas re-rendering and logs perf issues #3844

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f225168
chore: fix conflicts
adithyaakrishna Mar 30, 2026
898428d
chore: fix rerenders
adithyaakrishna Mar 30, 2026
4afba1c
chore: fix review changes
adithyaakrishna Mar 30, 2026
2831432
chore: fix review changes
adithyaakrishna Mar 30, 2026
d37302a
chore: fix review changes
adithyaakrishna Mar 30, 2026
0ec73b0
chore: fix review changes
adithyaakrishna Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: fix review changes
  • Loading branch information
@adithyaakrishna
adithyaakrishna committed Mar 31, 2026
commit 0ec73b0da7f969875fbdc36c6f06397fc846acfa
6 changes: 5 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,11 @@ function createRowSignalStore(): RowSignalStore & {
getOnSelectEntry: () => _onSelectEntry,
getOnToggleNode: () => _onToggleNode,
update(selectedEntryId, expandedNodes, onSelectEntry, onToggleNode) {
const changed = _selectedId !== selectedEntryId || _expandedNodes !== expandedNodes
const changed =
_selectedId !== selectedEntryId ||
_expandedNodes !== expandedNodes ||
_onSelectEntry !== onSelectEntry ||
_onToggleNode !== onToggleNode
_selectedId = selectedEntryId
_expandedNodes = expandedNodes
_onSelectEntry = onSelectEntry
Expand Down
1 change: 0 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-canvas-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ export function mapEdgesByNode(edges: Edge[], nodeIds: Set<string>): Map<string,
const list = result.get(edge.source) ?? []
list.push(edge)
result.set(edge.source, list)
return
}
if (nodeIds.has(edge.target)) {
const list = result.get(edge.target) ?? []
Expand Down