fix(chunks): add server-side sort to document chunks API

Chunk sort was previously done client-side on a single page of server-paginated data, which only reordered the current page. Now sort params (sortBy, sortOrder) flow through the full stack: types → service → API route → query hook → useDocumentChunks → document.tsx.
simstudioai · waleedlatif1 · Mar 29, 2026 · Mar 29, 2026 · Mar 29, 2026 · Mar 29, 2026
commit aeeec6b3bc8dde7462195b1fbef1a275e3f0bdb8
diff --git a/apps/sim/app/api/knowledge/[id]/documents/[documentId]/chunks/route.ts b/apps/sim/app/api/knowledge/[id]/documents/[documentId]/chunks/route.ts
@@ -15,6 +15,8 @@ const GetChunksQuerySchema = z.object({
   enabled: z.enum(['true', 'false', 'all']).optional().default('all'),
   limit: z.coerce.number().min(1).max(100).optional().default(50),
   offset: z.coerce.number().min(0).optional().default(0),
+  sortBy: z.enum(['chunkIndex', 'tokenCount', 'enabled']).optional().default('chunkIndex'),
+  sortOrder: z.enum(['asc', 'desc']).optional().default('asc'),
 })
 
 const CreateChunkSchema = z.object({
@@ -88,6 +90,8 @@ export async function GET(
       enabled: searchParams.get('enabled') || undefined,
       limit: searchParams.get('limit') || undefined,
       offset: searchParams.get('offset') || undefined,
+      sortBy: searchParams.get('sortBy') || undefined,
+      sortOrder: searchParams.get('sortOrder') || undefined,
     })
 
     const result = await queryChunks(documentId, queryParams, requestId)

diff --git a/apps/sim/app/workspace/[workspaceId]/home/components/user-input/user-input.tsx b/apps/sim/app/workspace/[workspaceId]/home/components/user-input/user-input.tsx
@@ -571,19 +571,19 @@ export function UserInput({
     const items = e.clipboardData?.items
     if (!items) return
 
-    const imageFiles: File[] = []
+    const pastedFiles: File[] = []
     for (const item of Array.from(items)) {
-      if (item.kind === 'file' && item.type.startsWith('image/')) {
+      if (item.kind === 'file') {
         const file = item.getAsFile()
-        if (file) imageFiles.push(file)
+        if (file) pastedFiles.push(file)
       }
     }
 
-    if (imageFiles.length === 0) return
+    if (pastedFiles.length === 0) return
 
     e.preventDefault()
     const dt = new DataTransfer()
-    for (const file of imageFiles) {
+    for (const file of pastedFiles) {
       dt.items.add(file)
     }
     filesRef.current.processFiles(dt.files)

diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
@@ -175,7 +175,21 @@ export function Document({
     refreshChunks: initialRefreshChunks,
     updateChunk: initialUpdateChunk,
     isFetching: isFetchingChunks,
-  } = useDocumentChunks(knowledgeBaseId, documentId, currentPageFromURL, '', enabledFilterParam)
+  } = useDocumentChunks(
+    knowledgeBaseId,
+    documentId,
+    currentPageFromURL,
+    '',
+    enabledFilterParam,
+    activeSort?.column === 'tokens'
+      ? 'tokenCount'
+      : activeSort?.column === 'status'
+        ? 'enabled'
+        : activeSort
+          ? 'chunkIndex'
+          : undefined,
+    activeSort?.direction
+  )
 
   const { data: searchResults = [], error: searchQueryError } = useDocumentChunkSearchQuery(
     {
@@ -241,25 +255,7 @@ export function Document({
 
   const rawDisplayChunks = showingSearch ? paginatedSearchResults : initialChunks
 
-  const displayChunks = useMemo(() => {
-    if (!activeSort || !rawDisplayChunks) return rawDisplayChunks ?? []
-    const { column, direction } = activeSort
-    return [...rawDisplayChunks].sort((a, b) => {
-      let cmp = 0
-      switch (column) {
-        case 'index':
-          cmp = a.chunkIndex - b.chunkIndex
-          break
-        case 'tokens':
-          cmp = (a.tokenCount ?? 0) - (b.tokenCount ?? 0)
-          break
-        case 'status':
-          cmp = (a.enabled ? 1 : 0) - (b.enabled ? 1 : 0)
-          break
-      }
-      return direction === 'asc' ? cmp : -cmp
-    })
-  }, [rawDisplayChunks, activeSort])
+  const displayChunks = rawDisplayChunks ?? []
 
   const currentPage = showingSearch ? searchCurrentPage : initialPage
   const totalPages = showingSearch ? searchTotalPages : initialTotalPages
@@ -871,10 +867,16 @@ export function Document({
         { id: 'status', label: 'Status' },
       ],
       active: activeSort,
-      onSort: (column, direction) => setActiveSort({ column, direction }),
-      onClear: () => setActiveSort(null),
+      onSort: (column, direction) => {
+        setActiveSort({ column, direction })
+        void goToPage(1)
+      },
+      onClear: () => {
+        setActiveSort(null)
+        void goToPage(1)
+      },
     }),
-    [activeSort]
+    [activeSort, goToPage]
   )
 
   const chunkRows: ResourceRow[] = useMemo(() => {

diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx
@@ -957,7 +957,7 @@ export function KnowledgeBase({
                 content: (
                   <Tooltip.Root>
                     <Tooltip.Trigger asChild>
-                      <div style={{ cursor: 'help' }}>{getStatusBadge(doc)}</div>
+                      <div className='cursor-help'>{getStatusBadge(doc)}</div>
                     </Tooltip.Trigger>
                     <Tooltip.Content side='top' className='max-w-xs'>
                       {doc.processingError}

diff --git a/...paceId]/w/components/sidebar/components/collapsed-sidebar-menu/collapsed-sidebar-menu.tsx b/...paceId]/w/components/sidebar/components/collapsed-sidebar-menu/collapsed-sidebar-menu.tsx
@@ -245,9 +245,6 @@ export function CollapsedTaskFlyoutItem({
           title={task.name}
           isActive={!!task.isActive}
           isUnread={!!task.isUnread}
-          statusIndicatorClassName={
-            !(isCurrentRoute || isMenuOpen) ? 'group-hover:hidden' : undefined
-          }
         />
       </Link>
       {showActions && (