Skip to content

improvement(sidebar): expand sidebar by hovering and clicking the edge #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Mar 28, 2026
Merged

improvement(sidebar): expand sidebar by hovering and clicking the edge #3830

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6ebb91
improvement(sidebar): expand sidebar by hovering and clicking the edge
waleedlatif1 Mar 28, 2026
1711004
improvement(sidebar): add keyboard shortcuts for new workflow/task, c…
waleedlatif1 Mar 28, 2026
577ead5
improvement(sidebar): use Tooltip.Shortcut for inline shortcut display
waleedlatif1 Mar 28, 2026
4f705d7
fix(sidebar): change new workflow shortcut from Mod+Shift+W to Mod+Sh…
waleedlatif1 Mar 28, 2026
3fad92b
fix(hotkeys): fall back to event.code for international keyboard layo…
waleedlatif1 Mar 28, 2026
ba03206
fix(sidebar): guard add-workflow shortcut with canEdit and isCreating…
waleedlatif1 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(hotkeys): fall back to event.code for international keyboard layo… 
…ut compatibility
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 28, 2026
commit 3fad92b6b0045526953dd45f93b8d31cf6447025
14 changes: 13 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/providers/global-commands-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,26 @@ function parseShortcut(shortcut: string): ParsedShortcut {
}
}

/**
* Maps a KeyboardEvent.code value to the logical key name used in shortcut definitions.
* Needed for international keyboard layouts where e.key may produce unexpected characters
* (e.g. macOS Option+letter yields 'å' instead of 'a', dead keys yield 'Dead').
*/
function codeToKey(code: string): string | undefined {
if (code.startsWith('Key')) return code.slice(3).toLowerCase()
if (code.startsWith('Digit')) return code.slice(5)
return undefined
}

function matchesShortcut(e: KeyboardEvent, parsed: ParsedShortcut): boolean {
const isMac = isMacPlatform()
const expectedCtrl = parsed.ctrl || (parsed.mod ? !isMac : false)
const expectedMeta = parsed.meta || (parsed.mod ? isMac : false)
const eventKey = e.key.length === 1 ? e.key.toLowerCase() : e.key
const keyMatches = eventKey === parsed.key || codeToKey(e.code) === parsed.key

return (
eventKey === parsed.key &&
keyMatches &&
!!e.ctrlKey === !!expectedCtrl &&
!!e.metaKey === !!expectedMeta &&
!!e.shiftKey === !!parsed.shift &&
Expand Down
Loading