Skip to content

feat(files): interactive markdown checkbox toggling in preview #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 8 commits into from
Mar 28, 2026
Merged

feat(files): interactive markdown checkbox toggling in preview #3829

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
11aea6b
feat(files): interactive markdown checkbox toggling in preview
waleedlatif1 Mar 28, 2026
a7e9399
fix(files): handle ordered-list checkboxes and fix index drift
waleedlatif1 Mar 28, 2026
853a2a7
lint
waleedlatif1 Mar 28, 2026
5721f70
fix(files): remove counter offset that prevented checkbox toggling
waleedlatif1 Mar 28, 2026
5f7c61f
fix(files): apply task-list styling to ordered lists too
waleedlatif1 Mar 28, 2026
5d7b4d9
fix(files): render single pass when interactive to avoid index drift
waleedlatif1 Mar 28, 2026
342696d
fix(files): move useMemo above conditional return to fix Rules of Hooks
waleedlatif1 Mar 28, 2026
51163c6
fix(files): pass content directly to preview when not streaming to av…
waleedlatif1 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(files): handle ordered-list checkboxes and fix index drift
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 28, 2026
commit a7e9399eeaf75d3cb924749cb67692659b34dfa6
11 changes: 7 additions & 4 deletions apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,10 +716,13 @@ function PptxPreview({

function toggleMarkdownCheckbox(markdown: string, targetIndex: number, checked: boolean): string {
let currentIndex = 0
return markdown.replace(/^(\s*[-*+]\s+)\[([ xX])\]/gm, (match, prefix: string) => {
if (currentIndex++ !== targetIndex) return match
return `${prefix}[${checked ? 'x' : ' '}]`
})
return markdown.replace(
/^(\s*(?:[-*+]|\d+[.)]) +)\[([ xX])\]/gm,
(match, prefix: string) => {
if (currentIndex++ !== targetIndex) return match
return `${prefix}[${checked ? 'x' : ' '}]`
}
)
}
Comment thread
waleedlatif1 marked this conversation as resolved.

const UnsupportedPreview = memo(function UnsupportedPreview({
Expand Down
7 changes: 7 additions & 0 deletions apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/preview-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,11 @@ const MarkdownPreview = memo(function MarkdownPreview({
[onCheckboxToggle]
)

const committedCheckboxCount = useMemo(
() => (committed ? (committed.match(/^[ \t]*(?:[-*+]|\d+[.)]) +\[[ xX]\]/gm) ?? []).length : 0),
[committed]
)

checkboxCounterRef.current = 0

const committedMarkdown = useMemo(
Expand All @@ -249,6 +254,8 @@ const MarkdownPreview = memo(function MarkdownPreview({
[committed, components]
Comment thread
waleedlatif1 marked this conversation as resolved.
)
Comment thread
waleedlatif1 marked this conversation as resolved.

checkboxCounterRef.current = committedCheckboxCount
Comment thread
waleedlatif1 marked this conversation as resolved.
Outdated

return (
<div ref={scrollRef} className='h-full overflow-auto p-6'>
{committedMarkdown}
Expand Down
Loading