fix(academy): blank mixed lesson, quiz canAdvance flag, empty-array v…

…alueNotEmpty
simstudioai · waleedlatif1 · Mar 28, 2026 · Feb 16, 2026 · Feb 17, 2026 · Feb 18, 2026
commit d32bb1e8a017ed8bfea662b9d0fc84f8ade08a4b
diff --git a/apps/sim/app/academy/[courseSlug]/[lessonSlug]/page.tsx b/apps/sim/app/academy/[courseSlug]/[lessonSlug]/page.tsx
@@ -41,12 +41,15 @@ export default function LessonPage({ params }: LessonPageProps) {
   const prevLesson = currentIndex > 0 ? allLessons[currentIndex - 1] : null
   const nextLesson = currentIndex < allLessons.length - 1 ? allLessons[currentIndex + 1] : null
 
-  const handleComplete = useCallback(() => setExerciseComplete(true), [])
+  const handleExerciseComplete = useCallback(() => setExerciseComplete(true), [])
+  const handleQuizPass = useCallback(() => setQuizComplete(true), [])
   const canAdvance =
     (!lesson?.exerciseConfig && !lesson?.quizConfig) ||
     (Boolean(lesson?.exerciseConfig) && Boolean(lesson?.quizConfig)
       ? exerciseComplete && quizComplete
-      : exerciseComplete)
+      : lesson?.exerciseConfig
+        ? exerciseComplete
+        : quizComplete)
 
   // Video lessons are considered complete once visited — no interactive gate required.
   useEffect(() => {
@@ -142,7 +145,7 @@ export default function LessonPage({ params }: LessonPageProps) {
           <ExerciseView
             lessonId={lesson.id}
             exerciseConfig={lesson.exerciseConfig!}
-            onComplete={handleComplete}
+            onComplete={handleExerciseComplete}
           />
         )}
 
@@ -152,19 +155,19 @@ export default function LessonPage({ params }: LessonPageProps) {
               <LessonQuiz
                 lessonId={lesson.id}
                 quizConfig={lesson.quizConfig!}
-                onPass={handleComplete}
+                onPass={handleQuizPass}
               />
             </div>
           </div>
         )}
 
         {lesson.lessonType === 'mixed' && (
           <>
-            {hasExercise && !exerciseComplete && (
+            {hasExercise && (!exerciseComplete || !hasQuiz) && (
               <ExerciseView
                 lessonId={lesson.id}
                 exerciseConfig={lesson.exerciseConfig!}
-                onComplete={handleComplete}
+                onComplete={handleExerciseComplete}
                 videoUrl={!hasQuiz ? lesson.videoUrl : undefined}
                 description={!hasQuiz ? lesson.description : undefined}
               />
@@ -176,7 +179,7 @@ export default function LessonPage({ params }: LessonPageProps) {
                   <LessonQuiz
                     lessonId={lesson.id}
                     quizConfig={lesson.quizConfig!}
-                    onPass={() => setQuizComplete(true)}
+                    onPass={handleQuizPass}
                   />
                 </div>
               </div>
@@ -188,7 +191,7 @@ export default function LessonPage({ params }: LessonPageProps) {
                   <LessonQuiz
                     lessonId={lesson.id}
                     quizConfig={lesson.quizConfig!}
-                    onPass={handleComplete}
+                    onPass={handleQuizPass}
                   />
                 </div>
               </div>

diff --git a/apps/sim/lib/academy/validation.ts b/apps/sim/lib/academy/validation.ts
@@ -48,7 +48,13 @@ function checkRule(
       return blocks.some((b) => {
         if (b.type !== rule.blockType) return false
         const value = b.subBlocks?.[rule.subBlockId]
-        if (rule.valueNotEmpty && (value === undefined || value === null || value === ''))
+        if (
+          rule.valueNotEmpty &&
+          (value === undefined ||
+            value === null ||
+            value === '' ||
+            (Array.isArray(value) && value.length === 0))
+        )
           return false
         if (rule.valuePattern) {
           let regex: RegExp