Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(rippling): guard startDate by operation and clarify totalCount de…
…scriptions

- Guard startDate/endDate with operation check to prevent candidateStartDate
  from clobbering date filters on leave/activity operations
- Update totalCount output descriptions on paginated tools to clarify it
  reflects page size, not total record count
  • Loading branch information
waleedlatif1 committed Mar 25, 2026
commit a73a0fb425d76bc23b303b7c48ca69ecabe43836
8 changes: 5 additions & 3 deletions apps/sim/blocks/blocks/rippling.ts
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,9 @@ export const RipplingBlock: BlockConfig = {
if (params.lastName) mapped.lastName = params.lastName
if (params.email) mapped.email = params.email
if (params.jobTitle) mapped.jobTitle = params.jobTitle
if (params.startDate) mapped.startDate = params.startDate
if (params.endDate) mapped.endDate = params.endDate
if (params.startDate && params.operation !== 'push_candidate')
mapped.startDate = params.startDate
if (params.endDate && params.operation !== 'push_candidate') mapped.endDate = params.endDate
if (params.status) mapped.status = params.status
if (params.managedBy) mapped.managedBy = params.managedBy

Expand All @@ -344,7 +345,8 @@ export const RipplingBlock: BlockConfig = {
if (params.groupName) mapped.name = params.groupName
if (params.candidatePhone) mapped.phone = params.candidatePhone
if (params.candidateDepartment) mapped.department = params.candidateDepartment
if (params.candidateStartDate) mapped.startDate = params.candidateStartDate
if (params.candidateStartDate && params.operation === 'push_candidate')
mapped.startDate = params.candidateStartDate
if (params.nextCursor) mapped.next = params.nextCursor

if (params.users) {
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/get_company_activity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const ripplingGetCompanyActivityTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of activity events returned',
description: 'Number of activity events returned on this page',
},
nextCursor: {
type: 'string',
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_custom_fields.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const ripplingListCustomFieldsTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of custom fields returned',
description: 'Number of custom fields returned on this page',
},
},
}
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_departments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const ripplingListDepartmentsTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of departments returned',
description: 'Number of departments returned on this page',
},
},
}
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_employees.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export const ripplingListEmployeesTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of employees returned',
description: 'Number of employees returned on this page',
},
},
}
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_employees_with_terminated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const ripplingListEmployeesWithTerminatedTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of employees returned',
description: 'Number of employees returned on this page',
},
},
}
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_leave_balances.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const ripplingListLeaveBalancesTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of leave balances returned',
description: 'Number of leave balances returned on this page',
},
},
}
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_levels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const ripplingListLevelsTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of levels returned',
description: 'Number of levels returned on this page',
},
},
}
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_teams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const ripplingListTeamsTool: ToolConfig<RipplingListTeamsParams, Rippling
},
totalCount: {
type: 'number',
description: 'Total number of teams returned',
description: 'Number of teams returned on this page',
},
},
}
2 changes: 1 addition & 1 deletion apps/sim/tools/rippling/list_work_locations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export const ripplingListWorkLocationsTool: ToolConfig<
},
totalCount: {
type: 'number',
description: 'Total number of work locations returned',
description: 'Number of work locations returned on this page',
},
},
}
Loading