Skip to content

fix(ui): fix kb id extraction logic for resource, sync tags #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 2 commits into from
Mar 25, 2026
Merged

fix(ui): fix kb id extraction logic for resource, sync tags #3763

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10a8ab7
fix(ui): fix kb id extraction logic for resource, sync tags
Mar 25, 2026
6968e42
Pass knowledge base id back on edit tag
Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Pass knowledge base id back on edit tag
  • Loading branch information
Theodore Li committed Mar 25, 2026
commit 6968e42cba56e6a8a6e7a9e929e80f2712f1cb72
30 changes: 30 additions & 0 deletions apps/sim/lib/copilot/resource-extraction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,36 @@ describe('extractResourcesFromToolResult', () => {
])
})

it('uses knowledgeBaseId from the tool result when update_tag args omit it', () => {
const resources = extractResourcesFromToolResult(
'knowledge_base',
{
operation: 'update_tag',
args: {
tagDefinitionId: 'tag_456',
},
},
{
success: true,
message: 'Tag updated successfully',
data: {
id: 'tag_456',
knowledgeBaseId: 'kb_123',
displayName: 'Priority',
fieldType: 'text',
},
}
)

expect(resources).toEqual([
{
type: 'knowledgebase',
id: 'kb_123',
title: 'Knowledge Base',
},
])
})

it('does not create resources for read-only knowledge base tag operations', () => {
const resources = extractResourcesFromToolResult(
'knowledge_base',
Expand Down
13 changes: 13 additions & 0 deletions apps/sim/lib/copilot/tools/server/knowledge/knowledge-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
deleteTagDefinition,
getDocumentTagDefinitions,
getNextAvailableSlot,
getTagDefinitionById,
getTagUsageStats,
updateTagDefinition,
} from '@/lib/knowledge/tags/service'
Expand Down Expand Up @@ -525,6 +526,7 @@ export const knowledgeBaseServerTool: BaseServerTool<KnowledgeBaseArgs, Knowledg
message: `Tag "${newTag.displayName}" created successfully`,
data: {
id: newTag.id,
knowledgeBaseId: args.knowledgeBaseId,
tagSlot: newTag.tagSlot,
displayName: newTag.displayName,
fieldType: newTag.fieldType,
Expand All @@ -551,12 +553,21 @@ export const knowledgeBaseServerTool: BaseServerTool<KnowledgeBaseArgs, Knowledg
}
}

const existingTag = await getTagDefinitionById(args.tagDefinitionId)
if (!existingTag) {
return {
success: false,
message: `Tag definition with ID "${args.tagDefinitionId}" not found`,
}
}

const requestId = crypto.randomUUID().slice(0, 8)
assertNotAborted()
const updatedTag = await updateTagDefinition(args.tagDefinitionId, updateData, requestId)

logger.info('Tag definition updated via copilot', {
tagId: args.tagDefinitionId,
knowledgeBaseId: existingTag.knowledgeBaseId,
userId: context.userId,
})

Expand All @@ -565,6 +576,7 @@ export const knowledgeBaseServerTool: BaseServerTool<KnowledgeBaseArgs, Knowledg
message: `Tag "${updatedTag.displayName}" updated successfully`,
data: {
id: updatedTag.id,
knowledgeBaseId: existingTag.knowledgeBaseId,
tagSlot: updatedTag.tagSlot,
displayName: updatedTag.displayName,
fieldType: updatedTag.fieldType,
Expand Down Expand Up @@ -605,6 +617,7 @@ export const knowledgeBaseServerTool: BaseServerTool<KnowledgeBaseArgs, Knowledg
success: true,
message: `Tag "${deleted.displayName}" deleted successfully. All document/chunk references cleared.`,
data: {
knowledgeBaseId: args.knowledgeBaseId,
tagSlot: deleted.tagSlot,
displayName: deleted.displayName,
},
Expand Down
Loading