Skip to content

feat(table): column drag-and-drop reorder #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 5 commits into from
Mar 24, 2026
Merged

feat(table): column drag-and-drop reorder #3738

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84013ff
feat(table): column drag-and-drop reorder
waleedlatif1 Mar 24, 2026
bae4aab
fix(table): remove duplicate onDragEnd call from handleDrop
waleedlatif1 Mar 24, 2026
ed1feca
fix(table): persist columnOrder on rename/delete and defer delete to …
waleedlatif1 Mar 24, 2026
12ced58
fix(table): prevent stale refs during column drag operations
waleedlatif1 Mar 24, 2026
161a0f3
fix(table): insert column at correct side when anchor is unordered
waleedlatif1 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(table): prevent stale refs during column drag operations 
Fix two bugs in column drag-and-drop:
1. Stale columnWidths ref during rename - compute updated widths inline
   before passing to updateMetadata
2. Escape-cancelled drag still reorders - update dropTargetColumnNameRef
   directly in handleColumnDragLeave to prevent handleColumnDragEnd from
   reading stale ref value

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Mar 24, 2026
commit 12ced58861f9b9473fd25efa44e520d48830ff90
13 changes: 8 additions & 5 deletions apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,15 +360,17 @@ export function Table({
const columnRename = useInlineRename({
onSave: (columnName, newName) => {
pushUndoRef.current({ type: 'rename-column', oldName: columnName, newName })
setColumnWidths((prev) => {
if (!(columnName in prev)) return prev
return { ...prev, [newName]: prev[columnName] }
})
let updatedWidths = columnWidthsRef.current
if (columnName in updatedWidths) {
const { [columnName]: width, ...rest } = updatedWidths
updatedWidths = { ...rest, [newName]: width }
setColumnWidths(updatedWidths)
}
const updatedOrder = columnOrderRef.current?.map((n) => (n === columnName ? newName : n))
if (updatedOrder) {
setColumnOrder(updatedOrder)
updateMetadataRef.current({
columnWidths: columnWidthsRef.current,
columnWidths: updatedWidths,
columnOrder: updatedOrder,
})
Comment thread
waleedlatif1 marked this conversation as resolved.
}
Expand Down Expand Up @@ -683,6 +685,7 @@ export function Table({
}, [])
Comment thread
waleedlatif1 marked this conversation as resolved.

const handleColumnDragLeave = useCallback(() => {
dropTargetColumnNameRef.current = null
setDropTargetColumnName(null)
}, [])

Expand Down
Loading