Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(tour): address remaining PR review comments
- Remove unused logger import and instance in product-tour.tsx
- Remove unused tour-tooltip-fade animation from tailwind config
- Remove unnecessary overflow-hidden wrapper around WorkflowTour
- Add border stroke to arrow SVG in tour-tooltip for visual consistency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
waleedlatif1 and claude committed Mar 24, 2026
commit 9c9c1f856e730c00358091b98f5db3d3d6d02b06
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use client'

import { useMemo } from 'react'
import { createLogger } from '@sim/logger'
import dynamic from 'next/dynamic'
import { usePathname } from 'next/navigation'
import { navTourSteps } from '@/app/workspace/[workspaceId]/components/product-tour/nav-tour-steps'
Expand All @@ -12,8 +11,6 @@ import {
} from '@/app/workspace/[workspaceId]/components/product-tour/tour-shared'
import { useTour } from '@/app/workspace/[workspaceId]/components/product-tour/use-tour'

const logger = createLogger('NavTour')

const Joyride = dynamic(() => import('react-joyride'), {
ssr: false,
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ export default function WorkflowLayout({ children }: { children: React.ReactNode
return (
<main className='flex h-full flex-1 flex-col overflow-hidden'>
<ErrorBoundary>{children}</ErrorBoundary>
<div className='absolute h-0 w-0 overflow-hidden'>
<WorkflowTour />
</div>
<WorkflowTour />
</main>
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,10 @@ function TourTooltip({
height={7}
viewBox='0 0 14 7'
preserveAspectRatio='none'
className='-mt-px fill-[var(--bg)]'
className='-mt-px fill-[var(--bg)] stroke-[var(--border)]'
>
<polygon points='0,0 14,0 7,7' />
<polygon points='0,0 14,0 7,7' className='stroke-none' />
<polyline points='0,0 7,7 14,0' fill='none' strokeWidth={1} />
</svg>
</PopoverPrimitive.Arrow>
</PopoverPrimitive.Content>
Expand Down
5 changes: 0 additions & 5 deletions apps/sim/tailwind.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,6 @@ export default {
from: { opacity: '0', transform: 'scale(0.96) translateY(4px)' },
to: { opacity: '1', transform: 'scale(1) translateY(0)' },
},
'tour-tooltip-fade': {
from: { opacity: '0' },
to: { opacity: '1' },
},
},
animation: {
'caret-blink': 'caret-blink 1.25s ease-out infinite',
Expand All @@ -202,7 +198,6 @@ export default {
'slide-in-right': 'slide-in-right 350ms ease-out forwards',
'slide-in-bottom': 'slide-in-bottom 400ms cubic-bezier(0.16, 1, 0.3, 1)',
'tour-tooltip-in': 'tour-tooltip-in 200ms cubic-bezier(0.25, 0.46, 0.45, 0.94)',
'tour-tooltip-fade': 'tour-tooltip-fade 150ms cubic-bezier(0.25, 0.46, 0.45, 0.94)',
},
},
},
Expand Down
Loading