Skip to content

improvement(react): replace unnecessary useEffect patterns with better React primitives #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 7 commits into from
Mar 19, 2026
Merged

improvement(react): replace unnecessary useEffect patterns with better React primitives #3675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3afc09d
improvement(react): replace unnecessary useEffect patterns with bette…
waleedlatif1 Mar 19, 2026
50b3987
fix(react): revert unsafe render-time side effects to useEffect
waleedlatif1 Mar 19, 2026
350f113
fix(react): restore useEffect for modals, scroll, and env sync
waleedlatif1 Mar 19, 2026
c56ff7a
fix(react): restore useEffect for help/invite modals, combobox index …
waleedlatif1 Mar 19, 2026
f8e8f7f
fix(context-menu): use requestAnimationFrame for ColorGrid focus, rem…
waleedlatif1 Mar 19, 2026
7dc680e
fix(files): restore filesRef pattern to prevent preview mode reset on…
waleedlatif1 Mar 19, 2026
4860ff8
fix(add-documents-modal, combobox): restore useEffect for modal reset…
waleedlatif1 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(add-documents-modal, combobox): restore useEffect for modal reset… 
…, fix combobox dep array

- add-documents-modal: handleOpenChange(true) is dead code in Radix
  controlled mode — restored useEffect watching open for reset-on-open
- combobox: depend on filteredOptions array (not .length) so highlight
  resets when items change even with same count
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 19, 2026
commit 4860ff862d9eb893bafac0c927031af1c626fe20
22 changes: 13 additions & 9 deletions ...space/[workspaceId]/knowledge/[id]/components/add-documents-modal/add-documents-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,21 @@ export function AddDocumentsModal({
}
}, [files])

/** Resets state on open and handles close with upload guard */
useEffect(() => {
if (open) {
setFiles([])
setFileError(null)
setIsDragging(false)
setDragCounter(0)
setRetryingIndexes(new Set())
clearError()
}
}, [open, clearError])

/** Handles close with upload guard */
const handleOpenChange = useCallback(
(newOpen: boolean) => {
if (newOpen) {
setFiles([])
setFileError(null)
setIsDragging(false)
setDragCounter(0)
setRetryingIndexes(new Set())
clearError()
} else {
if (!newOpen) {
if (isUploading) return
setFiles([])
setFileError(null)
Expand Down
4 changes: 2 additions & 2 deletions apps/sim/components/emcn/components/combobox/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,13 +466,13 @@ const Combobox = memo(
highlightedIndex >= 0 && highlightedIndex < filteredOptions.length ? highlightedIndex : -1
Comment thread
waleedlatif1 marked this conversation as resolved.

/**
* Reset highlighted index when filtered options shrink below it
* Reset highlighted index when filtered options change and index is out of bounds
*/
useEffect(() => {
if (highlightedIndex >= 0 && highlightedIndex >= filteredOptions.length) {
setHighlightedIndex(-1)
}
}, [filteredOptions.length, highlightedIndex])
}, [filteredOptions, highlightedIndex])

/**
* Scroll highlighted option into view
Expand Down
Loading