Skip to content

fix(open-resource): open resource tool to open existing files #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 4 commits into from
Mar 19, 2026
+123 −33
Merged

fix(open-resource): open resource tool to open existing files #3670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a73746b
fix(open-resource): open resource tool to open existing files
icecrasher321 Mar 19, 2026
609c6ce
fix loading state
icecrasher321 Mar 19, 2026
2affc59
address comment
icecrasher321 Mar 19, 2026
a36f390
remove title
icecrasher321 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove title
  • Loading branch information
@icecrasher321
icecrasher321 committed Mar 19, 2026
commit a36f390c4ecf8d26ea321265c5d98754ac580c88
4 changes: 1 addition & 3 deletions apps/sim/lib/copilot/orchestrator/tool-executor/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ function validateOpenResourceParams(
params: {
type: params.type,
id: params.id,
...(params.title ? { title: params.title } : {}),
},
}
}
Comment thread
icecrasher321 marked this conversation as resolved.
Expand Down Expand Up @@ -1039,7 +1038,6 @@ const SIM_WORKFLOW_TOOL_HANDLERS: Record<
const params = validated.params
const resourceType = params.type
const resourceId = params.id
const resourceTitle = params.title || resourceType

return {
success: true,
Expand All @@ -1048,7 +1046,7 @@ const SIM_WORKFLOW_TOOL_HANDLERS: Record<
{
type: resourceType as 'workflow' | 'table' | 'knowledgebase' | 'file',
id: resourceId,
title: resourceTitle,
title: resourceType,
},
],
}
Expand Down
2 changes: 0 additions & 2 deletions apps/sim/lib/copilot/orchestrator/tool-executor/param-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,9 @@ export type OpenResourceType = 'workflow' | 'table' | 'knowledgebase' | 'file'
export interface OpenResourceParams {
type?: OpenResourceType
id?: string
title?: string
}

export interface ValidOpenResourceParams {
type: OpenResourceType
id: string
title?: string
}
Loading