Skip to content

Include notification view in embedded workflow view #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 5 commits into from
Mar 17, 2026
Merged

Include notification view in embedded workflow view #3618

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44016ad
Include notification view in embedded workflow view
Mar 17, 2026
4ee9b4d
fix(ui) fix workflow not showing up when mothership calls run
Mar 17, 2026
fd9908d
Wire up fix in mothership
Mar 17, 2026
494f20e
Refresh events after workflow run
Mar 17, 2026
c260487
Fix so run workflow switches tabs as well
Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,18 @@ export function useChat(
) {
clientExecutionStarted.add(id)
const args = data?.arguments ?? data?.input ?? {}
const targetWorkflowId =
typeof (args as Record<string, unknown>).workflowId === 'string'
? ((args as Record<string, unknown>).workflowId as string)
: useWorkflowRegistry.getState().activeWorkflowId
if (targetWorkflowId) {
const meta = useWorkflowRegistry.getState().workflows[targetWorkflowId]
addResource({
type: 'workflow',
id: targetWorkflowId,
title: meta?.name ?? 'Workflow',
})
}
Comment thread
cursor[bot] marked this conversation as resolved.
executeRunToolOnClient(id, name, args as Record<string, unknown>)
}
break
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3922,7 +3922,7 @@ const WorkflowContent = React.memo(
</>
)}

{!embedded && <Notifications />}
<Notifications />
Comment thread
TheodoreSpeaks marked this conversation as resolved.
Outdated

{!embedded && isWorkflowReady && isWorkflowEmpty && effectivePermissions.canEdit && (
<CommandList />
Expand Down
Loading