Skip to content

fix(mothership): thinking and subagent text #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emir-karabeg merged 11 commits into from
Mar 17, 2026
Merged

fix(mothership): thinking and subagent text #3613

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4750dc5
Thinking v0
Sg312 Mar 16, 2026
1e9df2f
Change
Sg312 Mar 16, 2026
b7416e2
Fix
Sg312 Mar 16, 2026
4d4d53d
improvement(ui/ux): mothership chat experience
emir-karabeg Mar 17, 2026
1a8b817
user input animation
emir-karabeg Mar 17, 2026
eba19be
improvement(landing): desktop complete
emir-karabeg Mar 17, 2026
ee6c8c6
auth and 404
emir-karabeg Mar 17, 2026
bf8d159
mobile friendliness and home templates
emir-karabeg Mar 17, 2026
17c12ea
improvement(home): templates
emir-karabeg Mar 17, 2026
9ca0ab2
fix: feature flags
emir-karabeg Mar 17, 2026
4772899
address comments
emir-karabeg Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Thinking v0
  • Loading branch information
@Sg312 @emir-karabeg
Sg312 authored and emir-karabeg committed Mar 17, 2026
commit 4750dc58415780e66a056ce5e9bfcc9e2a1a9962
6 changes: 3 additions & 3 deletions ...pace/[workspaceId]/home/components/message-content/components/agent-group/agent-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@ export function AgentGroup({
status={item.data.status}
/>
) : (
<p
<div
key={`text-${idx}`}
className='whitespace-pre-wrap pl-[24px] font-base text-[13px] text-[var(--text-secondary)]'
className='ml-[24px] rounded-lg border border-[var(--divider)] bg-[var(--surface-4)] px-3 py-2 text-[13px] text-[var(--text-tertiary)] italic'
>
{item.content.trim()}
</p>
</div>
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
)
)}
</div>
Expand Down
26 changes: 20 additions & 6 deletions ...ce/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export interface CredentialTagData {

export type ContentSegment =
| { type: 'text'; content: string }
| { type: 'thinking'; content: string }
| { type: 'options'; data: OptionsTagData }
| { type: 'usage_upgrade'; data: UsageUpgradeTagData }
| { type: 'credential'; data: CredentialTagData }
Expand All @@ -36,7 +37,7 @@ export interface ParsedSpecialContent {
hasPendingTag: boolean
}

const SPECIAL_TAG_NAMES = ['options', 'usage_upgrade', 'credential'] as const
const SPECIAL_TAG_NAMES = ['thinking', 'options', 'usage_upgrade', 'credential'] as const

/**
* Parses inline special tags (`<options>`, `<usage_upgrade>`) from streamed
Expand Down Expand Up @@ -103,11 +104,17 @@ export function parseSpecialTags(content: string, isStreaming: boolean): ParsedS
}

const body = content.slice(bodyStart, closeIdx)
try {
const data = JSON.parse(body)
segments.push({ type: nearestTagName as 'options' | 'usage_upgrade' | 'credential', data })
} catch {
/* malformed JSON — drop the tag silently */
if (nearestTagName === 'thinking') {
if (body.trim()) {
segments.push({ type: 'thinking', content: body })
}
} else {
try {
const data = JSON.parse(body)
segments.push({ type: nearestTagName as 'options' | 'usage_upgrade' | 'credential', data })
} catch {
/* malformed JSON — drop the tag silently */
}
}

cursor = closeIdx + closeTag.length
Expand Down Expand Up @@ -137,6 +144,13 @@ interface SpecialTagsProps {
*/
export function SpecialTags({ segment, onOptionSelect }: SpecialTagsProps) {
switch (segment.type) {
/** TODO: FIX THINKING BLOCK RENDERING*/
case 'thinking':
return (
<div className='rounded-lg border border-[var(--divider)] bg-[var(--surface-4)] px-3 py-2 text-[13px] text-[var(--text-tertiary)] italic'>
{segment.content.trim()}
</div>
)
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
case 'options':
return <OptionsDisplay data={segment.data} onSelect={onOptionSelect} />
case 'usage_upgrade':
Expand Down
9 changes: 5 additions & 4 deletions apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,10 +513,11 @@ export function useChat(
streamingContentRef.current = ''
streamingBlocksRef.current = []

const ensureTextBlock = (): ContentBlock => {
const ensureTextBlock = (subagent?: boolean): ContentBlock => {
const wantType = subagent ? 'subagent_text' : 'text'
const last = blocks[blocks.length - 1]
if (last?.type === 'text') return last
const b: ContentBlock = { type: 'text', content: '' }
if (last?.type === wantType) return last
const b: ContentBlock = { type: wantType, content: '' }
blocks.push(b)
return b
}
Expand Down Expand Up @@ -607,7 +608,7 @@ export function useChat(
lastContentSource !== contentSource &&
runningText.length > 0 &&
!runningText.endsWith('\n')
const tb = ensureTextBlock()
const tb = ensureTextBlock(!!activeSubagent)
const normalizedChunk = needsBoundaryNewline ? `\n${chunk}` : chunk
tb.content = (tb.content ?? '') + normalizedChunk
runningText += normalizedChunk
Expand Down