Skip to content

fix(deploy): consolidate deployment detection into single source of truth #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 11 commits into from
Mar 16, 2026
Merged

fix(deploy): consolidate deployment detection into single source of truth #3606

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1fcff2b
fix(deploy): consolidate deployment detection into single source of t…
waleedlatif1 Mar 16, 2026
b6a2255
fix(deploy): address PR review feedback
waleedlatif1 Mar 16, 2026
2fa20f9
fix(deploy): clean up self-explanatory comments and fix unstable muta…
waleedlatif1 Mar 16, 2026
9a348c8
lint
waleedlatif1 Mar 16, 2026
71e604e
fix(deploy): skip expensive state merge when deployedState is null
waleedlatif1 Mar 16, 2026
3ea2628
fix(deploy): add missing workflow table import in deploy route
waleedlatif1 Mar 16, 2026
44df76d
fix(deploy): forward AbortSignal in fetchDeployedWorkflowState
waleedlatif1 Mar 16, 2026
c64a9fa
perf(deploy): parallelize all DB queries in checkNeedsRedeployment
waleedlatif1 Mar 16, 2026
250668f
fix(deploy): use sequential-then-parallel pattern in checkNeedsRedepl…
waleedlatif1 Mar 16, 2026
abd5b70
fix(deploy): use client-side comparison for editor header, remove ser…
waleedlatif1 Mar 16, 2026
f7cfa26
fix(deploy): suppress transient Update flash during deployed state re…
waleedlatif1 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(deploy): skip expensive state merge when deployedState is null 
Avoid running mergeSubblockStateWithValues on every render for
non-deployed workflows where changeDetected always returns false.
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 16, 2026
commit 71e604e58555dcec8ca640d63f539ea462eff8d4
3 changes: 2 additions & 1 deletion ...kspaceId]/w/[workflowId]/components/panel/components/deploy/hooks/use-change-detection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export function useChangeDetection({
const needsClientFallback = serverNeedsRedeployment === undefined && !isServerLoading

const currentState = useMemo((): WorkflowState | null => {
if (!needsClientFallback || !workflowId) return null
if (!needsClientFallback || !workflowId || !deployedState) return null

const mergedBlocks = mergeSubblockStateWithValues(blocks, subBlockValues ?? {})

Expand All @@ -112,6 +112,7 @@ export function useChangeDetection({
}, [
needsClientFallback,
workflowId,
deployedState,
blocks,
edges,
loops,
Expand Down
Loading