Skip to content

improvement(connectors): audit and harden all 30 knowledge base connectors #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Mar 15, 2026
Merged

improvement(connectors): audit and harden all 30 knowledge base connectors #3603

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a9b878
improvement(connectors): audit and harden all 30 knowledge base conne…
waleedlatif1 Mar 15, 2026
4649033
fix(oauth): update Notion test to match Basic Auth + JSON body config
waleedlatif1 Mar 15, 2026
839c00a
fix(connectors): address PR review comments for hubspot, jira, salesf…
waleedlatif1 Mar 15, 2026
5273649
fix(salesforce): revert ArticleBody — not a standard KnowledgeArticle…
waleedlatif1 Mar 15, 2026
441d2a6
fix(connectors): address second round of PR review comments
waleedlatif1 Mar 15, 2026
c29bc2b
fix(jira,outlook): replace raw fetch in downloadJiraAttachments, fix …
waleedlatif1 Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(oauth): update Notion test to match Basic Auth + JSON body config
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 15, 2026
commit 4649033e81ef47eba485eae340c609f63337debd
39 changes: 38 additions & 1 deletion apps/sim/lib/oauth/oauth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ describe('OAuth Token Refresh', () => {
providerId: 'outlook',
endpoint: 'https://login.microsoftonline.com/common/oauth2/v2.0/token',
},
{ name: 'Notion', providerId: 'notion', endpoint: 'https://api.notion.com/v1/oauth/token' },
{ name: 'Slack', providerId: 'slack', endpoint: 'https://slack.com/api/oauth.v2.access' },
{
name: 'Dropbox',
Expand Down Expand Up @@ -274,6 +273,44 @@ describe('OAuth Token Refresh', () => {
)
})

it.concurrent('should send Notion request with Basic Auth header and JSON body', async () => {
const mockFetch = createMockFetch(defaultOAuthResponse)
const refreshToken = 'test_refresh_token'

await withMockFetch(mockFetch, () => refreshOAuthToken('notion', refreshToken))

expect(mockFetch).toHaveBeenCalledWith(
'https://api.notion.com/v1/oauth/token',
expect.objectContaining({
method: 'POST',
headers: expect.objectContaining({
'Content-Type': 'application/json',
Authorization: expect.stringMatching(/^Basic /),
}),
body: expect.any(String),
})
)

const [, requestOptions] = mockFetch.mock.calls[0] as [
string,
{ headers: Record<string, string>; body: string },
]

const authHeader = requestOptions.headers.Authorization
const base64Credentials = authHeader.replace('Basic ', '')
const credentials = Buffer.from(base64Credentials, 'base64').toString('utf-8')
const [clientId, clientSecret] = credentials.split(':')

expect(clientId).toBe('notion_client_id')
expect(clientSecret).toBe('notion_client_secret')

const bodyParams = JSON.parse(requestOptions.body)
expect(bodyParams).toEqual({
grant_type: 'refresh_token',
refresh_token: refreshToken,
})
})

it.concurrent('should include User-Agent header for Reddit requests', async () => {
const mockFetch = createMockFetch(defaultOAuthResponse)
const refreshToken = 'test_refresh_token'
Expand Down
Loading