Skip to content

fix(workflow) Fix embedded workflow logs #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 4 commits into from
Mar 14, 2026
Merged

fix(workflow) Fix embedded workflow logs #3587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5367a9
Extract workflow run logic into shared util
Mar 14, 2026
9d6a87b
Fix lint
Mar 14, 2026
eff731b
Fix isRunning being stuck in true
Mar 14, 2026
da83159
Fix lint
Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
Theodore Li committed Mar 14, 2026
commit 9d6a87b18c1025591c576637e4ea03daf467f766
5 changes: 0 additions & 5 deletions apps/sim/app/api/workflows/[id]/execute/route.async.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ const {
}))

vi.mock('@/lib/auth/hybrid', () => ({
AuthType: {
SESSION: 'session',
API_KEY: 'api_key',
INTERNAL_JWT: 'internal_jwt',
},
checkHybridAuth: mockCheckHybridAuth,
AuthType: {
SESSION: 'session',
Expand Down
7 changes: 1 addition & 6 deletions apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,7 @@ import {
} from '@/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-execution-utils'
import { getBlock } from '@/blocks'
import type { SerializableExecutionState } from '@/executor/execution/types'
import type {
BlockLog,
BlockState,
ExecutionResult,
StreamingExecution,
} from '@/executor/types'
import type { BlockLog, BlockState, ExecutionResult, StreamingExecution } from '@/executor/types'
import { hasExecutionResult } from '@/executor/utils/errors'
import { coerceValue } from '@/executor/utils/start-block'
import { subscriptionKeys } from '@/hooks/queries/subscription'
Expand Down
13 changes: 11 additions & 2 deletions apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-execution-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ import type {
BlockErrorData,
BlockStartedData,
} from '@/lib/workflows/executor/execution-events'
import type { BlockLog, BlockState, ExecutionResult, NormalizedBlockOutput, StreamingExecution } from '@/executor/types'
import type {
BlockLog,
BlockState,
ExecutionResult,
NormalizedBlockOutput,
StreamingExecution,
} from '@/executor/types'
import { stripCloneSuffixes } from '@/executor/utils/subflow-utils'
import { useExecutionStore } from '@/stores/execution'
import type { ConsoleEntry, ConsoleUpdate } from '@/stores/terminal'
Expand Down Expand Up @@ -118,7 +124,10 @@ export interface BlockEventHandlerDeps {
* Creates block event handlers for SSE execution events.
* Shared by the workflow execution hook and standalone execution utilities.
*/
export function createBlockEventHandlers(config: BlockEventHandlerConfig, deps: BlockEventHandlerDeps) {
export function createBlockEventHandlers(
config: BlockEventHandlerConfig,
deps: BlockEventHandlerDeps
) {
const {
workflowId,
executionIdRef,
Expand Down
Loading