Skip to content

fix: enable workflow validation before deployment (was hardcoded to false) #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoyangzhen wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: enable workflow validation before deployment (was hardcoded to false) #3579

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1376793
fix: enable workflow validation before deployment
guoyangzhen Mar 14, 2026
70dd04d
fix: enable workflow validation in panel
guoyangzhen Mar 14, 2026
30c68ae
fix: include loops and parallels in validation (addressing review fee…
guoyangzhen Mar 14, 2026
d646ee1
fix: include loops and parallels in validation (addressing review fee…
guoyangzhen Mar 14, 2026
945b207
fix: memoize validation selector to prevent mutation and unnecessary …
guoyangzhen Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: include loops and parallels in validation (addressing review fee… 
…dback)
  • Loading branch information
@guoyangzhen
guoyangzhen committed Mar 14, 2026
commit d646ee1f0e2a25c2041a08e9debe483a0d916e66
2 changes: 2 additions & 0 deletions apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,8 @@ export const Panel = memo(function Panel() {
const result = validateWorkflowState({
blocks: state.blocks,
edges: state.edges,
loops: state.loops || {},
parallels: state.parallels || {},
})
return !result.valid
})
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
Expand Down