Skip to content

fix(tools): support stringified HTTP request tables #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 3 commits into from
Mar 14, 2026
Merged

fix(tools): support stringified HTTP request tables #3565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d02a78b
fix(tools): support stringified HTTP request tables
PlaneInABottle Mar 13, 2026
85ef000
test: mock AuthType in async execute route
Mar 13, 2026
af48016
test(tools): cover invalid stringified HTTP inputs
Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(tools): cover invalid stringified HTTP inputs
  • Loading branch information
test committed Mar 13, 2026
commit af48016b747993da1ae032f02455dc8534a31de1
17 changes: 17 additions & 0 deletions apps/sim/tools/http/request.stringified.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,21 @@ describe('HTTP Request Tool - Stringified Params Fix', () => {
)(params)
expect(body).toBe('grant_type=client_credentials')
})

it('should handle invalid JSON strings gracefully', () => {
const params = {
url: 'https://api.example.com/test',
method: 'GET' as const,
params: 'not-valid-json',
headers: '{broken',
}

const url = (requestTool.request.url as (input: RequestParams) => string)(params)
expect(url).toBe('https://api.example.com/test')

const headers = (
requestTool.request.headers as (input: RequestParams) => Record<string, string>
)(params)
expect(headers).toBeDefined()
})
})
2 changes: 1 addition & 1 deletion apps/sim/tools/http/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const getDefaultHeaders = (
export const processUrl = (
url: string,
pathParams?: Record<string, string>,
queryParams?: TableRow[] | Record<string, unknown> | string | null
queryParams?: TableRow[] | Record<string, any> | string | null
): string => {
if ((url.startsWith('"') && url.endsWith('"')) || (url.startsWith("'") && url.endsWith("'"))) {
url = url.slice(1, -1)
Expand Down
Loading