Skip to content

fix(execution): report cancellation durability truthfully #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 5 commits into from
Mar 14, 2026
Merged

fix(execution): report cancellation durability truthfully #3550

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4881f6
fix(cancel): report cancellation durability truthfully
PlaneInABottle Mar 12, 2026
2865ab3
fix: hoist cancellation test mocks
PlaneInABottle Mar 12, 2026
a99aba2
fix(sim): harden execution cancel durability
PlaneInABottle Mar 12, 2026
d6222b3
fix(sim): fallback manual cancel without redis
Mar 13, 2026
7aed473
test: mock AuthType in async execute route
Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(sim): harden execution cancel durability 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@PlaneInABottle @claude
2 people authored and test committed Mar 13, 2026
commit a99aba21a9a6f475d9c52baf2962c5fa72bdbd5a
2 changes: 1 addition & 1 deletion apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe('POST /api/workflows/[id]/executions/[executionId]/cancel', () => {
await expect(response.json()).resolves.toEqual({
success: false,
executionId: 'ex-1',
redisAvailable: false,
redisAvailable: true,
durablyRecorded: false,
reason: 'redis_write_failed',
})
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export async function POST(
return NextResponse.json({
success: cancellation.durablyRecorded,
executionId,
redisAvailable: cancellation.durablyRecorded,
redisAvailable: cancellation.reason !== 'redis_unavailable',
durablyRecorded: cancellation.durablyRecorded,
reason: cancellation.reason,
})
Expand Down