Skip to content

improvement(selectors): simplify selector context + add tests #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 3 commits into from
Mar 7, 2026
Merged

improvement(selectors): simplify selector context + add tests #3453

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1c6ed6
improvement(selectors): simplify selectorContext + add tests
icecrasher321 Mar 7, 2026
94abc42
fix resolve values fallback
icecrasher321 Mar 7, 2026
adea9db
another workflowid pass through
icecrasher321 Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix resolve values fallback
  • Loading branch information
@icecrasher321
icecrasher321 committed Mar 7, 2026
commit 94abc424be7f091ffcf0d3cdc93f5dadd90791e1
2 changes: 1 addition & 1 deletion apps/sim/lib/workflows/comparison/resolve-values.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export async function resolveValueForDisplay(

const selectorCtx = context.blockId
? extractSelectorContext(context.blockId, context.currentState, context.workflowId)
: {}
: { workflowId: context.workflowId }

// Credential fields (oauth-input or credential subBlockId)
const isCredentialField =
Expand Down