improvement(kb): modals, page layouts#2330
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryImproved UI/UX for knowledge base modals with better visual feedback and permission controls.
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant KnowledgeBase
participant DeleteButton
participant Tooltip
participant Modal
participant FileUpload
User->>KnowledgeBase: View knowledge base
KnowledgeBase->>DeleteButton: Render with disabled state check
alt User lacks edit permission
User->>DeleteButton: Hover over button
DeleteButton->>Tooltip: Show permission message
Tooltip-->>User: "Write permission required"
else User has edit permission
User->>DeleteButton: Click delete
DeleteButton->>Modal: Open delete dialog
end
User->>Modal: Open add/create documents modal
User->>FileUpload: Upload files
alt Upload fails
FileUpload->>Modal: Update file status to failed
Modal->>User: Show red border on file item
User->>FileUpload: Click retry button
FileUpload->>Modal: Retry upload
else Upload succeeds
FileUpload->>Modal: Update progress
end
alt Error occurs
Modal->>User: Display error in footer (left side)
end
User->>Modal: Click action buttons (right side)
|
| {uploadError.message} | ||
| </p> | ||
| ) : ( | ||
| <div /> |
Contributor
There was a problem hiding this comment.
style: empty <div /> used as placeholder - consider semantic alternative like <span className="flex-1" /> or remove if not needed for layout
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/add-documents-modal/add-documents-modal.tsx
Line: 348:348
Comment:
**style:** empty `<div />` used as placeholder - consider semantic alternative like `<span className="flex-1" />` or remove if not needed for layout
How can I resolve this? If you propose a fix, please make it concise.| {uploadError?.message || submitStatus?.message} | ||
| </p> | ||
| ) : ( | ||
| <div /> |
Contributor
There was a problem hiding this comment.
style: empty <div /> used as placeholder - consider semantic alternative like <span className="flex-1" /> or remove if not needed for layout
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsx
Line: 521:521
Comment:
**style:** empty `<div />` used as placeholder - consider semantic alternative like `<span className="flex-1" />` or remove if not needed for layout
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Solo.
Checklist