Skip to content

improvement: loading, optimistic actions #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 8 commits into from
Dec 5, 2025
Merged

improvement: loading, optimistic actions #2193

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2fc4037
improvement: loading, optimistic operations
emir-karabeg Dec 4, 2025
2b18c6b
improvement: folders update
emir-karabeg Dec 4, 2025
42536fd
fix usage indicator rounding + new tsconfig
icecrasher321 Dec 5, 2025
d1d1e23
Merge branch 'staging' into improvement/loading
icecrasher321 Dec 5, 2025
9114747
remove redundant checks
icecrasher321 Dec 5, 2025
094fad6
fix hmr case for missing workflow loads
icecrasher321 Dec 5, 2025
a706452
add abstraction for zustand/react hybrid optimism
icecrasher321 Dec 5, 2025
6e3d8a7
remove comments
icecrasher321 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improvement: folders update
  • Loading branch information
@emir-karabeg
emir-karabeg committed Dec 4, 2025
commit 2b18c6b21f0bd084796d7771e0db365cb4cbdac9
11 changes: 9 additions & 2 deletions apps/sim/hooks/queries/folders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,16 @@ export function useCreateFolder() {
// Snapshot previous state for rollback
const previousFolders = { ...useFolderStore.getState().folders }

// Calculate max sortOrder to place new folder at the bottom
const workspaceFolders = Object.values(previousFolders).filter(
(f) =>
f.workspaceId === variables.workspaceId && f.parentId === (variables.parentId || null)
)
const maxSortOrder = workspaceFolders.reduce((max, f) => Math.max(max, f.sortOrder), -1)

const tempId = `temp-folder-${Date.now()}`

// Optimistically add folder entry immediately
// Optimistically add folder entry immediately at the bottom
useFolderStore.setState((state) => ({
folders: {
...state.folders,
Expand All @@ -129,7 +136,7 @@ export function useCreateFolder() {
parentId: variables.parentId || null,
color: variables.color || '#808080',
isExpanded: false,
sortOrder: 0,
sortOrder: maxSortOrder + 1,
createdAt: new Date(),
updatedAt: new Date(),
},
Expand Down