fix(start): fix start block numbering#1909
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR implements consistent handling of start blocks across both legacy ( Key changes:
How it fits with the codebase: Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant ActionBar
participant CollaborativeWorkflow
participant WorkflowStore
participant Utils
participant TriggerUtils
Note over User,TriggerUtils: Start Block Duplication Prevention Flow
User->>ActionBar: Attempts to duplicate start block
ActionBar->>ActionBar: Check isStartBlock (starter OR start_trigger)
ActionBar->>CollaborativeWorkflow: collaborativeDuplicateBlock(blockId)
CollaborativeWorkflow->>WorkflowStore: Get source block
CollaborativeWorkflow->>CollaborativeWorkflow: Check if starter OR start_trigger
alt Is Start Block
CollaborativeWorkflow->>CollaborativeWorkflow: Log warning & return early
CollaborativeWorkflow-->>User: Duplication prevented
else Not Start Block
CollaborativeWorkflow->>Utils: getUniqueBlockName(sourceName, blocks)
alt Block name is "Start" or "Starter"
Utils->>Utils: Normalize name (lowercase, remove spaces)
Utils-->>CollaborativeWorkflow: Return "Start" (no number)
else Other block types
Utils->>Utils: Find highest number suffix
Utils-->>CollaborativeWorkflow: Return "BlockName N+1"
end
CollaborativeWorkflow->>WorkflowStore: Create new block with unique name
CollaborativeWorkflow-->>User: Block duplicated successfully
end
Note over User,TriggerUtils: Start Block Conflict Prevention Flow
User->>WorkflowStore: Attempts to add start_trigger
WorkflowStore->>TriggerUtils: wouldViolateSingleInstance(blocks, type)
TriggerUtils->>TriggerUtils: Check START_CONFLICT_TYPES array
alt Has legacy starter OR existing start_trigger
TriggerUtils-->>WorkflowStore: Violation detected
WorkflowStore-->>User: Addition blocked
else No conflicts
TriggerUtils-->>WorkflowStore: Allowed
WorkflowStore->>WorkflowStore: Add block
WorkflowStore-->>User: Block added successfully
end
|
Comment on lines
+24
to
+26
| if (normalizedBaseName === 'start' || normalizedBaseName === 'starter') { | ||
| return 'Start' | ||
| } |
Contributor
There was a problem hiding this comment.
style: early return bypasses duplicate name checking - verify that duplication prevention in use-collaborative-workflow.ts:1197 prevents naming conflicts when adding start blocks
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/stores/workflows/utils.ts
Line: 24:26
Comment:
**style:** early return bypasses duplicate name checking - verify that duplication prevention in `use-collaborative-workflow.ts:1197` prevents naming conflicts when adding start blocks
How can I resolve this? If you propose a fix, please make it concise.
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes start block numbering issue. Prevents duplication and if deleted then added, doesn't have a number suffix
Type of Change
Testing
Manual
Checklist