fix(start): fix start drag from toolbar#1882
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryFixed start block initialization when dragging from toolbar by ensuring subblocks receive proper default values. The PR addresses three key issues:
The changes ensure that when users drag the Start block from the toolbar, it appears with properly initialized input format fields instead of Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Toolbar
participant CollabWorkflow as useCollaborativeWorkflow
participant WorkflowStore
participant SubBlockStore
participant BlockConfig
User->>Toolbar: Drag Start block from toolbar
Toolbar->>CollabWorkflow: addBlock(type='start_trigger', ...)
CollabWorkflow->>BlockConfig: Get block configuration
BlockConfig-->>CollabWorkflow: startTriggerBlock config
CollabWorkflow->>CollabWorkflow: Initialize subBlocks
alt subBlock.value is function
CollabWorkflow->>CollabWorkflow: subBlock.value({})
else subBlock.defaultValue exists
CollabWorkflow->>CollabWorkflow: Use defaultValue
else subBlock.type === 'input-format'
CollabWorkflow->>CollabWorkflow: Create default entry with UUID
else subBlock.type === 'table'
CollabWorkflow->>CollabWorkflow: Initialize as []
end
CollabWorkflow->>WorkflowStore: addBlock(id, type, name, position, ...)
WorkflowStore->>WorkflowStore: resolveInitialSubblockValue(config)
WorkflowStore->>WorkflowStore: cloneInitialSubblockValue(resolved)
WorkflowStore->>SubBlockStore: setValue(blockId, subBlockId, value)
SubBlockStore-->>WorkflowStore: Value stored
WorkflowStore-->>CollabWorkflow: Block added
CollabWorkflow-->>User: Start block rendered with defaults
|
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
apps/sim/lib/workflows/defaults.ts, line 20-22 (link)logic:
cloneDefaultValueuses shallow cloning for objects, whilecloneInitialSubblockValueinstore.ts:35-43uses deep cloning. This inconsistency can cause shared reference bugs for nested objects.
4 files reviewed, 1 comment
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
* Fix start block * Fix webhook * Remove comments
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
* Fix start block * Fix webhook * Remove comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix start drag from toolbar
Type of Change
Testing
Manual
Checklist